Ordered include windows load children for a parent row the top-K holds only while refilling
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 18/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- typescript
- 領域
- data
調査の方向性
Start with the includes-work oracle in packages/db/tests/query/includes-work-counter-oracle.test.ts, which pins the three overshoot replays. The change belongs in the demand plane: packages/db/src/query/live/collection-config-builder.ts and the subset demand controller. Done means the replays no longer exceed the work bound, the work-bound exclusion is removed from the generated campaigns, and the readiness and demand oracles still pass.
索引モデルが issue の本文から書いたものです。
説明
Problem
An ordered live query with an index-backed parent window can load child rows for a parent row that its settled window does not show. The parent's ordered loader refills the window within one graph run. Until the refill completes, the top-K briefly holds a row outside the settled window, and the include routes that row. The child source then loads that row's children.
The published rows stay correct. The extra work is the children of one parent row for each such checkpoint.
Traces
The includes-work oracle (packages/db/tests/query/includes-work-counter-oracle.test.ts) pins these traces as replays. Each replay loads one child row more than the bound.
- A held row moves out. The parent query has
orderBy(rank),offset 1andlimit 1. A step moves the parent row at position 0 past every other rank. The top-K briefly shows the moved row before its loader refills the slot. That row's children load. - A tie at the window edge during preload. Two parent rows have the same rank at the window edge. The loader loads the tie after the first prefix. The window first shows one tied row, then the other row, and both rows load their children.
- A window move while the loader refills. A step moves a parent row, and a second step inserts a parent row with a copied rank. Then
setWindowmoves the window. The top-K briefly shows a row outside the moved window.
Why the published rows stay correct
The graph publishes only after the loader settles. The top-K retracts the transient row in the same graph run, so no subscriber receives it. Only the child demand sees the transient row, because setDemand takes effect when the include's parent keys change.
How the oracle observes it
The harness counts the change batches that the parent Collection delivers to the query. At preload, more batches than the initial load show that the ordered loader acquired more rows. After a step, more batches than the step's own parent write show the same. The generated campaigns skip the work bound at those checkpoints only (about 2.5% of them).
Proposed change
Hold include demand until the ordered loader settles. The include records demand changes during a graph run. When the live query's graph loop has no pending work and its loaders are idle, the include sends one net demand change. If that change loads child rows, the graph loop runs again. A transient parent row then adds and removes its key in the same loop, and the child source does not load it.
This change is in the demand plane (packages/db/src/query/live/collection-config-builder.ts and the subset demand controller). It can change when demand starts within a sync turn. The readiness and demand oracles must show that readiness stays correct.
After this change, remove the overshoot from the replays and the work-bound exclusion from the generated campaigns.
This issue was written by Isaac.
- 主要言語
- TypeScript
- スター
- 3.9k
- フォーク
- 277
- 平均マージ
- 22時間 54分
- マージ済み PR（30日）
- 236
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
TanStack/db のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 22/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 12/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 8/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 5/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
anomalyco/opencode#56380 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
-
BUG | `MCP 服务器` | 全局层行的停用/启用与删除报 404 server row not found，编辑保存会在 profile 层复制出重复行対応中かも @w6242652 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
Chocobozzz/PeerTube#7832 ·
メンテナーはふだん 3 日以内に返信
-
Pay to use?オープン
難易度 1/5 1時間未満 初心者へのやさしさ 66/100
darkreader/darkreader#16108 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信