Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

Ordered include windows load children for a parent row the top-K holds only while refilling

Đang mở
  • Có gì không ổn?
#2,151 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
18/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
typescript
Lĩnh vực
data

Hướng nghiên cứu

Start with the includes-work oracle in packages/db/tests/query/includes-work-counter-oracle.test.ts, which pins the three overshoot replays. The change belongs in the demand plane: packages/db/src/query/live/collection-config-builder.ts and the subset demand controller. Done means the replays no longer exceed the work bound, the work-bound exclusion is removed from the generated campaigns, and the readiness and demand oracles still pass.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Problem

An ordered live query with an index-backed parent window can load child rows for a parent row that its settled window does not show. The parent's ordered loader refills the window within one graph run. Until the refill completes, the top-K briefly holds a row outside the settled window, and the include routes that row. The child source then loads that row's children.

The published rows stay correct. The extra work is the children of one parent row for each such checkpoint.

Traces

The includes-work oracle (packages/db/tests/query/includes-work-counter-oracle.test.ts) pins these traces as replays. Each replay loads one child row more than the bound.

  1. A held row moves out. The parent query has orderBy(rank), offset 1 and limit 1. A step moves the parent row at position 0 past every other rank. The top-K briefly shows the moved row before its loader refills the slot. That row's children load.
  2. A tie at the window edge during preload. Two parent rows have the same rank at the window edge. The loader loads the tie after the first prefix. The window first shows one tied row, then the other row, and both rows load their children.
  3. A window move while the loader refills. A step moves a parent row, and a second step inserts a parent row with a copied rank. Then setWindow moves the window. The top-K briefly shows a row outside the moved window.

Why the published rows stay correct

The graph publishes only after the loader settles. The top-K retracts the transient row in the same graph run, so no subscriber receives it. Only the child demand sees the transient row, because setDemand takes effect when the include's parent keys change.

How the oracle observes it

The harness counts the change batches that the parent Collection delivers to the query. At preload, more batches than the initial load show that the ordered loader acquired more rows. After a step, more batches than the step's own parent write show the same. The generated campaigns skip the work bound at those checkpoints only (about 2.5% of them).

Proposed change

Hold include demand until the ordered loader settles. The include records demand changes during a graph run. When the live query's graph loop has no pending work and its loaders are idle, the include sends one net demand change. If that change loads child rows, the graph loop runs again. A transient parent row then adds and removes its key in the same loop, and the child source does not load it.

This change is in the demand plane (packages/db/src/query/live/collection-config-builder.ts and the subset demand controller). It can change when demand starts within a sync turn. The readiness and demand oracles must show that readiness stays correct.

After this change, remove the overshoot from the replays and the work-bound exclusion from the generated campaigns.

This issue was written by Isaac.

Ngôn ngữ chính
TypeScript
Star
3.9k
Fork
272
Merge trung bình
1 ngày 48 phút
Pull request đã merge (30 ngày)
238

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/db

Tất cả issue của TanStack/db

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.