Temporary CLI edits retain and replay superseded assignments without a bound
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- swift
- 領域
- performance
調査の方向性
Start by reading Sources/StableBar/BarStore.swift around applyEdits and Sources/StableBar/ConfigurationEditing.swift around editedMainDocument, then trace how structural edits and external file reloads affect replay order. Determine how to compact superseded assignments while preserving temporary changes across reloads and save or discard behavior; done means repeated updates do not retain and replay an ever growing history without changing those documented semantics.
索引モデルが issue の本文から書いたものです。
説明
What happens
Every successful temporary CLI edit is retained for the whole session, including older --set operations that a later assignment completely supersedes. Each subsequent command reconstructs the configuration by replaying that growing list.
A long-running automation that repeatedly changes one text field therefore retains command history rather than only the effective temporary change. The source shows unbounded retained operations and increasing replay work on the main actor. Actual latency, memory use and CPU use have not been measured, so this report does not claim a measured leak or a particular slowdown.
Steps to reproduce
Proposed isolated reproduction, not executed during this review:
-
Create a disposable directory (
scratch=$(mktemp -d)). Save this configuration as$scratch/config.jsonand start StableBar with--config "$scratch/config.json", so the test does not edit the personal bar:{"widgets":[{"id":"status","type":"text","position":"right","text":"Initial"}]} -
Repeatedly update that same widget without
--persist, for example alternate these commands:StableBar --config "$scratch/config.json" --set status '{"text":"A"}' StableBar --config "$scratch/config.json" --set status '{"text":"B"}' -
Keep the same session active without Reset, Discard, Save or switching screen setups. Inspect the retained
sessionEditsand the operations replayed on the next command or file reload.
The current implementation appends one retained operation per successful command. The widget needs only the latest text value, but old assignments remain. A loop is not included or run against the reporter's bar.
Expected
Repeated assignments to one unchanged widget property should not retain and replay every superseded value forever. Keep the documented session behavior: temporary changes remain separate from saved Settings changes, survive external file reloads, and can be saved or discarded explicitly.
See Command-line controls. The existing --set interface should remain safe for a long-running session; this report does not request a new provider or CLI command.
Environment
- Found by static review of main
01bf12a1a67f6083342421efa090e48213fbe62e. - The same
applyEditsretention exists in latest stablev0.17.0(9ac8fb042aff9e5fa65805835dcfeaddb4777f59). - No runtime reproduction, benchmark, app launch or automated test was performed.
- The installed reporting app is 0.17.0, build 1187; no observed resource figures from it are asserted here.
- Reporting workstation: macOS 27.0, build 26A428, arm64. No resource-use observations from it are implied.
Evidence
- BarStore.swift:365–379,
applyEdits: buildsallEdits = sessionEdits + edits, computes the new document, and stores the whole combined list unlesspersistis true. There is no deduplication or semantic compaction on this path. - ConfigurationEditing.swift:41–46,
editedMainDocument: replays every edit incustomizationEdits + sessionEdits, or in the explicitly supplied replay list, over the file document. - BarStore.swift:4–5:
BarStoreis@MainActor;applyEditsinvokes that reconstruction synchronously.
For scale only, one successful update every five seconds adds 24 × 60 × 60 / 5 = 17,280 operations per day. That is arithmetic from the retention rule, not a benchmark or a measurement of this workstation.
Diagnosis
The temporary overlay is represented as an ever-growing operation log. Even when the effective state is still one overridden field, appending a command copies/extends the old list and the next reconstruction applies the entire history. With N retained assignments, replay does work proportional to N before loading the resulting configuration.
Compact only semantically superseded assignments, or otherwise represent effective temporary state without losing its meaning. Preserve ordering around structural operations such as add, remove, unset, reorder, profile and package changes, and preserve rebasing over external file changes. Dropping an arbitrary oldest N operations can silently change the result. Persisting every live update would change the documented temporary behavior and write user configuration unnecessarily.
Related
- #161, released in 0.6.0, reduces repeated composition and debounces Settings controls. It does not compact temporary CLI history; the current retention/replay path remains.
- #151, closed without merging, proposed caching compositions within one edit. That is distinct from bounding superseded operations across a long session.
- #298 was declined because an event-driven script widget already covers pushing content. This report does not reopen
--pushor request a new provider. It concerns the resource behavior of already supported--setedits, including configuration properties rather than only data output. - #299 was declined as a live event-stream feature. No event stream is requested here.
No matching issue or PR was found in all-state temporary/CLI searches, plus focused replay, sessionEdits, temporary-edits and unbounded-history searches. The retention path remains in latest stable and pinned main.
Triaged by OMP (closerouter/openai/gpt-6.1-sol).
- 主要言語
- Swift
- スター
- 184
- フォーク
- 12
- 平均マージ
- 3時間 50分
- マージ済み PR(30日)
- 387
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Seb-GRAF/StableBar のほかの issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
メンテナーはふだん 1 日以内に返信
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display change対応中かも @Jonathanm10 が今日担当しました。 オープンneeds-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 30/100
メンテナーはふだん 1 日以内に返信
-
Allow the App Menu to display the frontmost app icon対応中かも @khatami10 が今日担当しました。 オープンenhancement needs-triage
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
Seb-GRAF/StableBar の issue をすべて見る
似ている issue
-
good first issue help wanted testing
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
-
area:cli documentation good first issue priority:low
難易度 1/5 1時間未満 初心者へのやさしさ 94/100
isaaclins/freesnitch#430 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信