Temporary CLI edits retain and replay superseded assignments without a bound

Aperta
#753 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
swift
Ambito
performance

Direzione di ricerca

Start by reading Sources/StableBar/BarStore.swift around applyEdits and Sources/StableBar/ConfigurationEditing.swift around editedMainDocument, then trace how structural edits and external file reloads affect replay order. Determine how to compact superseded assignments while preserving temporary changes across reloads and save or discard behavior; done means repeated updates do not retain and replay an ever growing history without changing those documented semantics.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug needs-info

What happens

Every successful temporary CLI edit is retained for the whole session, including older --set operations that a later assignment completely supersedes. Each subsequent command reconstructs the configuration by replaying that growing list.

A long-running automation that repeatedly changes one text field therefore retains command history rather than only the effective temporary change. The source shows unbounded retained operations and increasing replay work on the main actor. Actual latency, memory use and CPU use have not been measured, so this report does not claim a measured leak or a particular slowdown.

Steps to reproduce

Proposed isolated reproduction, not executed during this review:

  1. Create a disposable directory (scratch=$(mktemp -d)). Save this configuration as $scratch/config.json and start StableBar with --config "$scratch/config.json", so the test does not edit the personal bar:

    {"widgets":[{"id":"status","type":"text","position":"right","text":"Initial"}]}
    
  2. Repeatedly update that same widget without --persist, for example alternate these commands:

    StableBar --config "$scratch/config.json" --set status '{"text":"A"}'
    StableBar --config "$scratch/config.json" --set status '{"text":"B"}'
    
  3. Keep the same session active without Reset, Discard, Save or switching screen setups. Inspect the retained sessionEdits and the operations replayed on the next command or file reload.

The current implementation appends one retained operation per successful command. The widget needs only the latest text value, but old assignments remain. A loop is not included or run against the reporter's bar.

Expected

Repeated assignments to one unchanged widget property should not retain and replay every superseded value forever. Keep the documented session behavior: temporary changes remain separate from saved Settings changes, survive external file reloads, and can be saved or discarded explicitly.

See Command-line controls. The existing --set interface should remain safe for a long-running session; this report does not request a new provider or CLI command.

Environment

  • Found by static review of main 01bf12a1a67f6083342421efa090e48213fbe62e.
  • The same applyEdits retention exists in latest stable v0.17.0 (9ac8fb042aff9e5fa65805835dcfeaddb4777f59).
  • No runtime reproduction, benchmark, app launch or automated test was performed.
  • The installed reporting app is 0.17.0, build 1187; no observed resource figures from it are asserted here.
  • Reporting workstation: macOS 27.0, build 26A428, arm64. No resource-use observations from it are implied.

Evidence

  • BarStore.swift:365–379, applyEdits: builds allEdits = sessionEdits + edits, computes the new document, and stores the whole combined list unless persist is true. There is no deduplication or semantic compaction on this path.
  • ConfigurationEditing.swift:41–46, editedMainDocument: replays every edit in customizationEdits + sessionEdits, or in the explicitly supplied replay list, over the file document.
  • BarStore.swift:4–5: BarStore is @MainActor; applyEdits invokes that reconstruction synchronously.

For scale only, one successful update every five seconds adds 24 × 60 × 60 / 5 = 17,280 operations per day. That is arithmetic from the retention rule, not a benchmark or a measurement of this workstation.

Diagnosis

The temporary overlay is represented as an ever-growing operation log. Even when the effective state is still one overridden field, appending a command copies/extends the old list and the next reconstruction applies the entire history. With N retained assignments, replay does work proportional to N before loading the resulting configuration.

Compact only semantically superseded assignments, or otherwise represent effective temporary state without losing its meaning. Preserve ordering around structural operations such as add, remove, unset, reorder, profile and package changes, and preserve rebasing over external file changes. Dropping an arbitrary oldest N operations can silently change the result. Persisting every live update would change the documented temporary behavior and write user configuration unnecessarily.

Related

  • #161, released in 0.6.0, reduces repeated composition and debounces Settings controls. It does not compact temporary CLI history; the current retention/replay path remains.
  • #151, closed without merging, proposed caching compositions within one edit. That is distinct from bounding superseded operations across a long session.
  • #298 was declined because an event-driven script widget already covers pushing content. This report does not reopen --push or request a new provider. It concerns the resource behavior of already supported --set edits, including configuration properties rather than only data output.
  • #299 was declined as a live event-stream feature. No event stream is requested here.

No matching issue or PR was found in all-state temporary/CLI searches, plus focused replay, sessionEdits, temporary-edits and unbounded-history searches. The retention path remains in latest stable and pinned main.

Triaged by OMP (closerouter/openai/gpt-6.1-sol).

Lingua principale
Swift
Stelle
184
Fork
12
Merge medio
3h 50m
PR unite (30g)
387

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Seb-GRAF/StableBar

Tutte le issue di Seb-GRAF/StableBar

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.