Add event for incoming TAB_COMPLETE requests (pre-forward, cancellable)

オープン
#1,900 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
java
領域
api

調査の方向性

Start by reading the existing tab completion and command event APIs, especially TabCompleteEvent, PlayerAvailableCommandsEvent, and packet forwarding for TAB_COMPLETE. Trace how incoming packets reach the backend and how event results can cancel or replace responses. Done means plugins can receive this request before forwarding and cancel it or supply a replacement response; the issue names no source files or tests.

索引モデルが issue の本文から書いたものです。

説明

type: feature
Requested Feature

Add an event that fires before an incoming TAB_COMPLETE (Command Suggestions Request) packet is forwarded from the proxy to the backend, allowing plugins to cancel it or replace the response.

@Subscribe
public void onTabCompleteRequest(TabCompleteRequestEvent e) {
    // e.getPlayer(), e.getPartialMessage() ("ver", "plugins", ...)
    e.setResult(TabCompleteRequestEvent.Result.denied()); // packet dropped, backend never sees it
}
Why is this needed?

Anti plugin detection plugins on the proxy. Mods like Ui-Utils don't use the client's command tree - they send raw TAB_COMPLETE("ver") packets. The proxy forwards them to the backend, the backend replies with its plugin/software list, and the scanner fingerprints the network.

Existing API can't stop this:

  • TabCompleteEvent - doesn't fire for 1.13+.
  • PlayerAvailableCommandsEvent - only changes the client tree, scanners ignore it.
  • CommandExecuteEvent - not relevant.
  • Registering fake commands with empty suggest() - works only for known names, breaks on namespaced/unknown names, hijacks real commands.

Today the only reliable fix is packetevents or a custom netty handler, both work around the lack of a public API. A first-class hook would let proxy plugins block scanners cleanly without external dependencies.

Alternative Solutions
  1. TabCompleteEvent - legacy clients only, doesn't fire for 1.13+.
  2. PlayerAvailableCommandsEvent - tree-only; scanners bypass it with raw packets. Verified: removing commands from the root node still doesn't stop Ui-Utils.
  3. Fake commands with empty suggest() - fragile, incomplete, hijacks real commands, bypassed by namespaced names.
  4. packetevents - works, but requires an external dependency for a common proxy-level concern.
  5. Custom netty handler - reimplements packetevents, uses non-public API, breaks on updates.
Additional Information

Proof the packet reaches the proxy, with packetevents, this blocks scanners completely:

public void onPacketReceive(PacketReceiveEvent event) {
    if (event.getPacketType() == PacketType.Play.Client.TAB_COMPLETE) {
        WrapperPlayClientTabComplete packet = new WrapperPlayClientTabComplete(event);
        String command = packet.getText().toLowerCase().split(" ")[0];
        if (shouldBlock(command)) event.setCancelled(true);
    }
}
主要言語
Java
スター
2.3k
フォーク
983
平均マージ
4日 14時間
マージ済み PR(30日)
3

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

PaperMC/Velocity のほかの issue

PaperMC/Velocity の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。