Add event for incoming TAB_COMPLETE requests (pre-forward, cancellable)

Abierto
#1,900 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java
Área
api

Línea de trabajo

Start by reading the existing tab completion and command event APIs, especially TabCompleteEvent, PlayerAvailableCommandsEvent, and packet forwarding for TAB_COMPLETE. Trace how incoming packets reach the backend and how event results can cancel or replace responses. Done means plugins can receive this request before forwarding and cancel it or supply a replacement response; the issue names no source files or tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

type: feature
Requested Feature

Add an event that fires before an incoming TAB_COMPLETE (Command Suggestions Request) packet is forwarded from the proxy to the backend, allowing plugins to cancel it or replace the response.

@Subscribe
public void onTabCompleteRequest(TabCompleteRequestEvent e) {
    // e.getPlayer(), e.getPartialMessage() ("ver", "plugins", ...)
    e.setResult(TabCompleteRequestEvent.Result.denied()); // packet dropped, backend never sees it
}
Why is this needed?

Anti plugin detection plugins on the proxy. Mods like Ui-Utils don't use the client's command tree - they send raw TAB_COMPLETE("ver") packets. The proxy forwards them to the backend, the backend replies with its plugin/software list, and the scanner fingerprints the network.

Existing API can't stop this:

  • TabCompleteEvent - doesn't fire for 1.13+.
  • PlayerAvailableCommandsEvent - only changes the client tree, scanners ignore it.
  • CommandExecuteEvent - not relevant.
  • Registering fake commands with empty suggest() - works only for known names, breaks on namespaced/unknown names, hijacks real commands.

Today the only reliable fix is packetevents or a custom netty handler, both work around the lack of a public API. A first-class hook would let proxy plugins block scanners cleanly without external dependencies.

Alternative Solutions
  1. TabCompleteEvent - legacy clients only, doesn't fire for 1.13+.
  2. PlayerAvailableCommandsEvent - tree-only; scanners bypass it with raw packets. Verified: removing commands from the root node still doesn't stop Ui-Utils.
  3. Fake commands with empty suggest() - fragile, incomplete, hijacks real commands, bypassed by namespaced names.
  4. packetevents - works, but requires an external dependency for a common proxy-level concern.
  5. Custom netty handler - reimplements packetevents, uses non-public API, breaks on updates.
Additional Information

Proof the packet reaches the proxy, with packetevents, this blocks scanners completely:

public void onPacketReceive(PacketReceiveEvent event) {
    if (event.getPacketType() == PacketType.Play.Client.TAB_COMPLETE) {
        WrapperPlayClientTabComplete packet = new WrapperPlayClientTabComplete(event);
        String command = packet.getText().toLowerCase().split(" ")[0];
        if (shouldBlock(command)) event.setCancelled(true);
    }
}
Lenguaje dominante
Java
Estrellas
2.3k
Forks
983
Merge medio
4 d 14 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PaperMC/Velocity

Todos los issues de PaperMC/Velocity

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.