A state machine that fails at run time is reported as passing (0.11.0 reported the failure)

オープン
#2,358 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
go
領域
cli, testing

調査の方向性

Start by tracing handleBehaviorRunError, which the issue says records the failure on the behavior and returns nil, then follow how explore outcomes and -advance consume that result. Reproduce with the supplied SysML model and CLI commands, comparing develop with v0.11.0. Done means run failures reach the outcome, JSON output, and nonzero exit status as expected.

索引モデルが issue の本文から書いたものです。

説明

What happened, and what you expected instead

When a transition effect or an entry action fails at run time, the machine ends there and takes no further event, and the run is reported as passing: ✓, "status": "holds", proved over schedules, exit 0. The error appears only under -trace. v0.11.0 reported the failure and exited non-zero.

Same with division by zero in place of the index, with the failing assignment in an entry action, and under the default schedule (-instantiate E::sys -state … -advance 3: 0.11.0 prints advance failed: … and exits 2; develop prints ✓ Advanced to 3.0, Current state: <none>, exit 0).

Expected: the machine ending is fine; the failure of the machine -state names should reach the outcome, -json and the exit status, as it did in 0.11.0.

handleBehaviorRunError records the failure on the behavior and returns nil; I did not find where the explore outcome or -advance reads it back. Happy to send a patch if you say which shape you want.

Reproduction
$ sysml m.sysml -schedule "explore:runs=2,depth=200" -state "E::W::run E::sys.w" -advance 3

v0.11.0 (exit 1):
✗ explored E::W::run: 1 outcome (0 values, 1 error), 1 of 1 linearization failing
error: exhibited state machine run of object #4: process event: fire transition out of idle: transition effect: eval assignment RHS: index out of range: sequence index 1 is outside 1..0

v0.12.1 and develop (exit 0):
✓ explored E::W::run: 1 outcome
visits idle; this.isSolid = true; this.n = 0; this.xs = []
  standing: outcomes (proved over schedules: 1 linearization, inputs as written)

m.sysml:
package E {
  private import ScalarValues::*;
  private import SI::*;
  item def Ask;
  port def P { out item ask : Ask; }
  part def W { port p : ~P; attribute xs : Integer[0..*]; attribute n : Integer = 0;
    exhibit state run { entry; then idle; state idle;
      transition first idle accept Ask via p do action { assign n := n + xs#(1); } then idle; } }
  part def S { port a : P;
    exhibit state run { entry; then s0; state s0;
      transition first s0 accept after 1 [SI::s] do action { send new Ask() via a; } then s0; } }
  part sys { part s : S; part w : W; connect s.a to w.p; }
}
Version

v0.12.1-2309-g5797854cb (develop); also v0.12.1 release. v0.11.0 release reports the failure.

Surface

CLI (sysml)

Platform

Linux amd64

主要言語
Go
スター
59
フォーク
20
平均マージ
10時間 52分
マージ済み PR(30日)
903

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Open-MBEE/OpenSysML のほかの issue

Open-MBEE/OpenSysML の issue をすべて見る

似ている issue

Go の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。