A state machine that fails at run time is reported as passing (0.11.0 reported the failure)

Abierto
#2,358 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go
Área
cli, testing

Línea de trabajo

Start by tracing handleBehaviorRunError, which the issue says records the failure on the behavior and returns nil, then follow how explore outcomes and -advance consume that result. Reproduce with the supplied SysML model and CLI commands, comparing develop with v0.11.0. Done means run failures reach the outcome, JSON output, and nonzero exit status as expected.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happened, and what you expected instead

When a transition effect or an entry action fails at run time, the machine ends there and takes no further event, and the run is reported as passing: ✓, "status": "holds", proved over schedules, exit 0. The error appears only under -trace. v0.11.0 reported the failure and exited non-zero.

Same with division by zero in place of the index, with the failing assignment in an entry action, and under the default schedule (-instantiate E::sys -state … -advance 3: 0.11.0 prints advance failed: … and exits 2; develop prints ✓ Advanced to 3.0, Current state: <none>, exit 0).

Expected: the machine ending is fine; the failure of the machine -state names should reach the outcome, -json and the exit status, as it did in 0.11.0.

handleBehaviorRunError records the failure on the behavior and returns nil; I did not find where the explore outcome or -advance reads it back. Happy to send a patch if you say which shape you want.

Reproduction
$ sysml m.sysml -schedule "explore:runs=2,depth=200" -state "E::W::run E::sys.w" -advance 3

v0.11.0 (exit 1):
✗ explored E::W::run: 1 outcome (0 values, 1 error), 1 of 1 linearization failing
error: exhibited state machine run of object #4: process event: fire transition out of idle: transition effect: eval assignment RHS: index out of range: sequence index 1 is outside 1..0

v0.12.1 and develop (exit 0):
✓ explored E::W::run: 1 outcome
visits idle; this.isSolid = true; this.n = 0; this.xs = []
  standing: outcomes (proved over schedules: 1 linearization, inputs as written)

m.sysml:
package E {
  private import ScalarValues::*;
  private import SI::*;
  item def Ask;
  port def P { out item ask : Ask; }
  part def W { port p : ~P; attribute xs : Integer[0..*]; attribute n : Integer = 0;
    exhibit state run { entry; then idle; state idle;
      transition first idle accept Ask via p do action { assign n := n + xs#(1); } then idle; } }
  part def S { port a : P;
    exhibit state run { entry; then s0; state s0;
      transition first s0 accept after 1 [SI::s] do action { send new Ask() via a; } then s0; } }
  part sys { part s : S; part w : W; connect s.a to w.p; }
}
Version

v0.12.1-2309-g5797854cb (develop); also v0.12.1 release. v0.11.0 release reports the failure.

Surface

CLI (sysml)

Platform

Linux amd64

Lenguaje dominante
Go
Estrellas
59
Forks
20
Merge medio
10 h 52 min
PR fusionados (30 d)
903

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Open-MBEE/OpenSysML

Todos los issues de Open-MBEE/OpenSysML

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.