A state machine that fails at run time is reported as passing (0.11.0 reported the failure)

Aperta
#2,358 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
cli, testing

Direzione di ricerca

Start by tracing handleBehaviorRunError, which the issue says records the failure on the behavior and returns nil, then follow how explore outcomes and -advance consume that result. Reproduce with the supplied SysML model and CLI commands, comparing develop with v0.11.0. Done means run failures reach the outcome, JSON output, and nonzero exit status as expected.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happened, and what you expected instead

When a transition effect or an entry action fails at run time, the machine ends there and takes no further event, and the run is reported as passing: ✓, "status": "holds", proved over schedules, exit 0. The error appears only under -trace. v0.11.0 reported the failure and exited non-zero.

Same with division by zero in place of the index, with the failing assignment in an entry action, and under the default schedule (-instantiate E::sys -state … -advance 3: 0.11.0 prints advance failed: … and exits 2; develop prints ✓ Advanced to 3.0, Current state: <none>, exit 0).

Expected: the machine ending is fine; the failure of the machine -state names should reach the outcome, -json and the exit status, as it did in 0.11.0.

handleBehaviorRunError records the failure on the behavior and returns nil; I did not find where the explore outcome or -advance reads it back. Happy to send a patch if you say which shape you want.

Reproduction
$ sysml m.sysml -schedule "explore:runs=2,depth=200" -state "E::W::run E::sys.w" -advance 3

v0.11.0 (exit 1):
✗ explored E::W::run: 1 outcome (0 values, 1 error), 1 of 1 linearization failing
error: exhibited state machine run of object #4: process event: fire transition out of idle: transition effect: eval assignment RHS: index out of range: sequence index 1 is outside 1..0

v0.12.1 and develop (exit 0):
✓ explored E::W::run: 1 outcome
visits idle; this.isSolid = true; this.n = 0; this.xs = []
  standing: outcomes (proved over schedules: 1 linearization, inputs as written)

m.sysml:
package E {
  private import ScalarValues::*;
  private import SI::*;
  item def Ask;
  port def P { out item ask : Ask; }
  part def W { port p : ~P; attribute xs : Integer[0..*]; attribute n : Integer = 0;
    exhibit state run { entry; then idle; state idle;
      transition first idle accept Ask via p do action { assign n := n + xs#(1); } then idle; } }
  part def S { port a : P;
    exhibit state run { entry; then s0; state s0;
      transition first s0 accept after 1 [SI::s] do action { send new Ask() via a; } then s0; } }
  part sys { part s : S; part w : W; connect s.a to w.p; }
}
Version

v0.12.1-2309-g5797854cb (develop); also v0.12.1 release. v0.11.0 release reports the failure.

Surface

CLI (sysml)

Platform

Linux amd64

Lingua principale
Go
Stelle
59
Fork
20
Merge medio
10h 52m
PR unite (30g)
903

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Open-MBEE/OpenSysML

Tutte le issue di Open-MBEE/OpenSysML

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.