HTTP: an HTTP/1.1 request with no Host line, or with two, is served

オープン
#2,386 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
34/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c

調査の方向性

The issue gives the reproduction on a server-db build at 3450dff5, the make http, make asan-http, and make tsan-http targets, and docs/BUILTINS.md as relevant entry points. First run the same raw requests through Node's http and Go's net/http and record their behavior. Done means the decision covers all three RFC cases and HTTP/1.0 without Host; if adopted, the listed requests and affected suite requests are verified on all three targets, or if rejected, the documented behavior is clear.

索引モデルが issue の本文から書いたものです。

説明

area:http kind:decision

Found while writing the decision of #2370 (what the server refuses). Run on a server-db build of phase2-numbers at 3450dff5, each request written to a socket as bytes, to a code route that returns http_request_header of "host":

The request Answer What the route reads for host
GET /f HTTP/1.1, Host: h 200 ["h"]
GET /f HTTP/1.1, no Host line 200 []
GET /f HTTP/1.1, Host: h, Host: other 200 ["h", "other"]
GET /f HTTP/1.0, no Host line 200 []

RFC 9112, section 3.2: "A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field line or a Host header field with an invalid field value."

It is kept out of #2370 on purpose. It does not change where a request's head or body ends, and it changes what a hand-written client and many of the suite's own raw requests get, so it is its own decision with its own list of changed rows.

The decision to make

Whether the server answers 400 to an HTTP/1.1 request with no Host line and to any request with two, and what it does with a Host value that is not a host.

Done when

  • The decision is recorded here: the three cases of the RFC's sentence, each refused or served, and what HTTP/1.0 without Host gets. With what Node's http and Go's net/http do for the same bytes, run and not quoted.

If it is adopted:

  • The four requests of the table, and each of them with the Host line's name in three letter cases, are answered as the decision says, on make http, make asan-http and make tsan-http; a refused request reaches no route.
  • Every raw request of the suite that carries no Host line and expects to be served is changed in the same pull request, and the pull request counts them.
  • docs/BUILTINS.md says it where it says what the server refuses.

If it is rejected:

  • docs/BUILTINS.md says that a request is served without a Host line and with several, and that a route which uses the host must check http_request_header of "host" itself.

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。