HTTP: an HTTP/1.1 request with no Host line, or with two, is served

Abierto
#2,386 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
34/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c

Línea de trabajo

The issue gives the reproduction on a server-db build at 3450dff5, the make http, make asan-http, and make tsan-http targets, and docs/BUILTINS.md as relevant entry points. First run the same raw requests through Node's http and Go's net/http and record their behavior. Done means the decision covers all three RFC cases and HTTP/1.0 without Host; if adopted, the listed requests and affected suite requests are verified on all three targets, or if rejected, the documented behavior is clear.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:http kind:decision

Found while writing the decision of #2370 (what the server refuses). Run on a server-db build of phase2-numbers at 3450dff5, each request written to a socket as bytes, to a code route that returns http_request_header of "host":

The request Answer What the route reads for host
GET /f HTTP/1.1, Host: h 200 ["h"]
GET /f HTTP/1.1, no Host line 200 []
GET /f HTTP/1.1, Host: h, Host: other 200 ["h", "other"]
GET /f HTTP/1.0, no Host line 200 []

RFC 9112, section 3.2: "A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field line or a Host header field with an invalid field value."

It is kept out of #2370 on purpose. It does not change where a request's head or body ends, and it changes what a hand-written client and many of the suite's own raw requests get, so it is its own decision with its own list of changed rows.

The decision to make

Whether the server answers 400 to an HTTP/1.1 request with no Host line and to any request with two, and what it does with a Host value that is not a host.

Done when

  • The decision is recorded here: the three cases of the RFC's sentence, each refused or served, and what HTTP/1.0 without Host gets. With what Node's http and Go's net/http do for the same bytes, run and not quoted.

If it is adopted:

  • The four requests of the table, and each of them with the Host line's name in three letter cases, are answered as the decision says, on make http, make asan-http and make tsan-http; a refused request reaches no route.
  • Every raw request of the suite that carries no Host line and expects to be served is changed in the same pull request, and the pull request counts them.
  • docs/BUILTINS.md says it where it says what the server refuses.

If it is rejected:

  • docs/BUILTINS.md says that a request is served without a Host line and with several, and that a route which uses the host must check http_request_header of "host" itself.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.