HTTP: an HTTP/1.1 request with no Host line, or with two, is served
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 34/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- c
- Ambito
- backend, networking
Direzione di ricerca
The issue gives the reproduction on a server-db build at 3450dff5, the make http, make asan-http, and make tsan-http targets, and docs/BUILTINS.md as relevant entry points. First run the same raw requests through Node's http and Go's net/http and record their behavior. Done means the decision covers all three RFC cases and HTTP/1.0 without Host; if adopted, the listed requests and affected suite requests are verified on all three targets, or if rejected, the documented behavior is clear.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Found while writing the decision of #2370 (what the server refuses). Run on a server-db build of phase2-numbers at 3450dff5, each request written to a socket as bytes, to a code route that returns http_request_header of "host":
| The request | Answer | What the route reads for host |
|---|---|---|
GET /f HTTP/1.1, Host: h |
200 |
["h"] |
GET /f HTTP/1.1, no Host line |
200 |
[] |
GET /f HTTP/1.1, Host: h, Host: other |
200 |
["h", "other"] |
GET /f HTTP/1.0, no Host line |
200 |
[] |
RFC 9112, section 3.2: "A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field line or a Host header field with an invalid field value."
It is kept out of #2370 on purpose. It does not change where a request's head or body ends, and it changes what a hand-written client and many of the suite's own raw requests get, so it is its own decision with its own list of changed rows.
The decision to make
Whether the server answers 400 to an HTTP/1.1 request with no Host line and to any request with two, and what it does with a Host value that is not a host.
Done when
- The decision is recorded here: the three cases of the RFC's sentence, each refused or served, and what HTTP/1.0 without
Hostgets. With what Node'shttpand Go'snet/httpdo for the same bytes, run and not quoted.
If it is adopted:
- The four requests of the table, and each of them with the
Hostline's name in three letter cases, are answered as the decision says, onmake http,make asan-httpandmake tsan-http; a refused request reaches no route. - Every raw request of the suite that carries no
Hostline and expects to be served is changed in the same pull request, and the pull request counts them. -
docs/BUILTINS.mdsays it where it says what the server refuses.
If it is rejected:
-
docs/BUILTINS.mdsays that a request is served without aHostline and with several, and that a route which uses the host must checkhttp_request_header of "host"itself.
— Claude DevBox
- Lingua principale
- C
- Stelle
- 3
- Fork
- 7
- Merge medio
- 3h 28m
- PR unite (30g)
- 270
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
InauguralSystems/EigenScript#2476 ·
I maintainer di solito rispondono entro 1 giorno
-
area:gates needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
InauguralSystems/EigenScript#2462 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameApertaarea:gates kind:gate-defect needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
InauguralSystems/EigenScript#2461 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area:gates kind:gate-defect needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
InauguralSystems/EigenScript#2458 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordApertaarea:http kind:silent-wrong
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
InauguralSystems/EigenScript#2394 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di InauguralSystems/EigenScript
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
flipperdevices/flipperzero-firmware#4520 ·
I maintainer di solito rispondono entro 1 giorno
-
area/build-framework kind/enhancement priority/low
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
yugabyte/yugabyte-db#38826 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
meshcore-dev/MeshCore#3891 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug grammar sev-3
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
BUG/MEDIUM: regex: worker SIGSEGV when a regex is applied to an empty body on libc-regex buildsApertastatus: needs-triage type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100