HTTP: an HTTP/1.1 request with no Host line, or with two, is served

Aperta
#2,386 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
34/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c

Direzione di ricerca

The issue gives the reproduction on a server-db build at 3450dff5, the make http, make asan-http, and make tsan-http targets, and docs/BUILTINS.md as relevant entry points. First run the same raw requests through Node's http and Go's net/http and record their behavior. Done means the decision covers all three RFC cases and HTTP/1.0 without Host; if adopted, the listed requests and affected suite requests are verified on all three targets, or if rejected, the documented behavior is clear.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:http kind:decision

Found while writing the decision of #2370 (what the server refuses). Run on a server-db build of phase2-numbers at 3450dff5, each request written to a socket as bytes, to a code route that returns http_request_header of "host":

The request Answer What the route reads for host
GET /f HTTP/1.1, Host: h 200 ["h"]
GET /f HTTP/1.1, no Host line 200 []
GET /f HTTP/1.1, Host: h, Host: other 200 ["h", "other"]
GET /f HTTP/1.0, no Host line 200 []

RFC 9112, section 3.2: "A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field line or a Host header field with an invalid field value."

It is kept out of #2370 on purpose. It does not change where a request's head or body ends, and it changes what a hand-written client and many of the suite's own raw requests get, so it is its own decision with its own list of changed rows.

The decision to make

Whether the server answers 400 to an HTTP/1.1 request with no Host line and to any request with two, and what it does with a Host value that is not a host.

Done when

  • The decision is recorded here: the three cases of the RFC's sentence, each refused or served, and what HTTP/1.0 without Host gets. With what Node's http and Go's net/http do for the same bytes, run and not quoted.

If it is adopted:

  • The four requests of the table, and each of them with the Host line's name in three letter cases, are answered as the decision says, on make http, make asan-http and make tsan-http; a refused request reaches no route.
  • Every raw request of the suite that carries no Host line and expects to be served is changed in the same pull request, and the pull request counts them.
  • docs/BUILTINS.md says it where it says what the server refuses.

If it is rejected:

  • docs/BUILTINS.md says that a request is served without a Host line and with several, and that a route which uses the host must check http_request_header of "host" itself.

— Claude DevBox

Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 28m
PR unite (30g)
270

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.