Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

String-scaling gate misses quadratic len-of scans because length is measured outside the timer

オープン
  • 何か問題がありますか？
#1,192 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
c, shell
領域
performance, testing-qa

調査の方向性

Start with tests/test_string_scaling.sh and inspect the builtin_len change described in the issue. Reproduce the current and mutant timings with the supplied commands, then add separately timed len-of-in-loop coverage with a cache-removal control, or narrow the gate's stated coverage. Preserve the existing indexing coverage and verify the gate distinguishes both regressions.

索引モデルが issue の本文から書いたものです。

説明

area:gates found-by:critic kind:gate-defect

The string-scaling gate enrolled by PR #1187 claims len of coverage in its header, but its only len of s call is before t0. The timed scan uses the saved n, so removal of the length cache in builtin_len is invisible to it.

Independently reproduced at 0c680102cfe6ac7f961c8a0eb76267a00fed0605. The only runtime mutation was:

 Value* builtin_len(Value *arg) {
@@
     if (arg->type == VAL_STR)
-        return make_num(val_str_len(arg));
+        return make_num(strlen(arg->data.strv.ptr));

I compiled that translation unit with the release recipe and linked it with the current release objects. No fake runtime, timing stub, environment replay, or altered gate was involved. The modified runtime returns the same lengths.

The untouched gate passed three times at 2.01, 2.01, 2.02 (rc 0). It would pass the former 2.60 threshold as well as 2.90. Meanwhile the real pre-#1185 indexing binary failed three times at 4.34, 4.52, 4.48; the instrument still detects that original regression.

To expose the missed class, I extracted the gate's actual scan program and changed only its loop condition from i < n to i < (len of s). Five interleaved release/mutant samples per length, JIT off, all child exits 0 and all scan counts correct:

Runtime 20k median ms 40k 80k Doubling ratios
Current release 12.023219 23.421235 48.285582 1.948, 2.062
builtin_len cache removed 38.151753 140.258292 471.863735 3.676, 3.364

This is a workload-coverage class, not a claim that changing the threshold caused this hole: a named operation used only in setup cannot contribute its complexity to the verdict. Add a separately timed len of-in-loop workload (with a real cache-removal fault control), or narrow the stated coverage explicitly. Retain separate indexing coverage rather than blending timings so one operation can dilute another.

Local reproduction artifacts: /tmp/strenrol-r4/real-regression.py, len-regression/commands.json, len-regression/mutation.diff, real-gate-results.json, scan-len.eigs, and len-loop-samples.json.

cd /home/jon/src/InauguralSystems/EigenScriptEcosystem/EigenScript
EIGS=/tmp/strenrol-r4/len-regression/eigenscript bash tests/test_string_scaling.sh
EIGS_JIT_OFF=1 /tmp/strenrol-r4/len-regression/eigenscript /tmp/strenrol-r4/scan-len.eigs 80000
主要言語
C
スター
3
フォーク
7
平均マージ
3時間 58分
マージ済み PR（30日）
105

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。