Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

String-scaling gate misses quadratic len-of scans because length is measured outside the timer

Aperta
  • Qualcosa non va?
#1,192 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
c, shell
Ambito
performance, testing-qa

Direzione di ricerca

Start with tests/test_string_scaling.sh and inspect the builtin_len change described in the issue. Reproduce the current and mutant timings with the supplied commands, then add separately timed len-of-in-loop coverage with a cache-removal control, or narrow the gate's stated coverage. Preserve the existing indexing coverage and verify the gate distinguishes both regressions.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:gates found-by:critic kind:gate-defect

The string-scaling gate enrolled by PR #1187 claims len of coverage in its header, but its only len of s call is before t0. The timed scan uses the saved n, so removal of the length cache in builtin_len is invisible to it.

Independently reproduced at 0c680102cfe6ac7f961c8a0eb76267a00fed0605. The only runtime mutation was:

 Value* builtin_len(Value *arg) {
@@
     if (arg->type == VAL_STR)
-        return make_num(val_str_len(arg));
+        return make_num(strlen(arg->data.strv.ptr));

I compiled that translation unit with the release recipe and linked it with the current release objects. No fake runtime, timing stub, environment replay, or altered gate was involved. The modified runtime returns the same lengths.

The untouched gate passed three times at 2.01, 2.01, 2.02 (rc 0). It would pass the former 2.60 threshold as well as 2.90. Meanwhile the real pre-#1185 indexing binary failed three times at 4.34, 4.52, 4.48; the instrument still detects that original regression.

To expose the missed class, I extracted the gate's actual scan program and changed only its loop condition from i < n to i < (len of s). Five interleaved release/mutant samples per length, JIT off, all child exits 0 and all scan counts correct:

Runtime 20k median ms 40k 80k Doubling ratios
Current release 12.023219 23.421235 48.285582 1.948, 2.062
builtin_len cache removed 38.151753 140.258292 471.863735 3.676, 3.364

This is a workload-coverage class, not a claim that changing the threshold caused this hole: a named operation used only in setup cannot contribute its complexity to the verdict. Add a separately timed len of-in-loop workload (with a real cache-removal fault control), or narrow the stated coverage explicitly. Retain separate indexing coverage rather than blending timings so one operation can dilute another.

Local reproduction artifacts: /tmp/strenrol-r4/real-regression.py, len-regression/commands.json, len-regression/mutation.diff, real-gate-results.json, scan-len.eigs, and len-loop-samples.json.

cd /home/jon/src/InauguralSystems/EigenScriptEcosystem/EigenScript
EIGS=/tmp/strenrol-r4/len-regression/eigenscript bash tests/test_string_scaling.sh
EIGS_JIT_OFF=1 /tmp/strenrol-r4/len-regression/eigenscript /tmp/strenrol-r4/scan-len.eigs 80000
Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 58m
PR unite (30g)
105

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.