Import: re-check an unknown import outcome once Studio can read the job again

オープン
#1,957 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
1〜2日
初心者へのやさしさ
42/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript

調査の方向性

Start with the unknown-outcome handling described in src/features/instance/databases/DESIGN.md and the import flow it covers, then see where get_job polling ends in the outcome. The open decisions are when a recheck runs (dialog or table open, or a background check) and how a recheck that finds no job keeps the outcome unknown. Done means a later successful read can replace unknown with completed or failed, and a miss never turns unknown into a failure. Confirm the cluster caveat with the maintainers before building it.

索引モデルが issue の本文から書いたものです。

説明

What happens

After #1955, an import that Studio stops following ends as Outcome unknown. That covers five failed get_job polls in a row, the 10-minute deadline, and a job the polled node doesn't have. Studio says the import may still be running or may have finished, and points to the table and the Jobs tab.

One case in there is a real failure that Studio reports as unknown. The job reaches ERROR on the server between Studio's last good poll and the five failed ones. Studio never reads the ERROR, so it can't call the import failed. That part is by design: Studio can't report an outcome it never observed. #1955 records it in src/features/instance/databases/DESIGN.md.

Possible improvement

Once Studio can reach the instance again, it could check that job once more and replace the unknown outcome with the real one. It would say that the import completed, or that it failed with the job's message. That could happen the next time the import dialog or table is opened, or on a slow background check while the page stays open.

The catch: get_job reads only the node it reaches, because hdb_job doesn't replicate. So on a cluster, a recheck can miss the job just as the original polls did. A recheck that doesn't find the job should leave the outcome unknown, never turn it into a failure.

Low priority. The current outcome is honest, and the user is already told to check the table before importing again.

Review-Deferral: 1ebd2884610ec52c severity=nit category=correctness

Raised by the cross-model review of #1955 (#1939).

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

主要言語
TypeScript
スター
5
フォーク
4
平均マージ
1日 19時間
マージ済み PR(30日)
144

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

HarperFast/studio のほかの issue

HarperFast/studio の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。