Import: re-check an unknown import outcome once Studio can read the job again

Abierto
  • ¿Algo no está bien?
#1,957 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
42/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
databases, frontend

Línea de trabajo

Start with the unknown-outcome handling described in src/features/instance/databases/DESIGN.md and the import flow it covers, then see where get_job polling ends in the outcome. The open decisions are when a recheck runs (dialog or table open, or a background check) and how a recheck that finds no job keeps the outcome unknown. Done means a later successful read can replace unknown with completed or failed, and a miss never turns unknown into a failure. Confirm the cluster caveat with the maintainers before building it.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

After #1955, an import that Studio stops following ends as Outcome unknown. That covers five failed get_job polls in a row, the 10-minute deadline, and a job the polled node doesn't have. Studio says the import may still be running or may have finished, and points to the table and the Jobs tab.

One case in there is a real failure that Studio reports as unknown. The job reaches ERROR on the server between Studio's last good poll and the five failed ones. Studio never reads the ERROR, so it can't call the import failed. That part is by design: Studio can't report an outcome it never observed. #1955 records it in src/features/instance/databases/DESIGN.md.

Possible improvement

Once Studio can reach the instance again, it could check that job once more and replace the unknown outcome with the real one. It would say that the import completed, or that it failed with the job's message. That could happen the next time the import dialog or table is opened, or on a slow background check while the page stays open.

The catch: get_job reads only the node it reaches, because hdb_job doesn't replicate. So on a cluster, a recheck can miss the job just as the original polls did. A recheck that doesn't find the job should leave the outcome unknown, never turn it into a failure.

Low priority. The current outcome is honest, and the user is already told to check the table before importing again.

Review-Deferral: 1ebd2884610ec52c severity=nit category=correctness

Raised by the cross-model review of #1955 (#1939).

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lenguaje dominante
TypeScript
Estrellas
5
Forks
4
Merge medio
1 d 19 h
PR fusionados (30 d)
144

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de HarperFast/studio

Todos los issues de HarperFast/studio

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.