Import: re-check an unknown import outcome once Studio can read the job again

Aperta
  • Qualcosa non va?
#1,957 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
databases, frontend

Direzione di ricerca

Start with the unknown-outcome handling described in src/features/instance/databases/DESIGN.md and the import flow it covers, then see where get_job polling ends in the outcome. The open decisions are when a recheck runs (dialog or table open, or a background check) and how a recheck that finds no job keeps the outcome unknown. Done means a later successful read can replace unknown with completed or failed, and a miss never turns unknown into a failure. Confirm the cluster caveat with the maintainers before building it.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happens

After #1955, an import that Studio stops following ends as Outcome unknown. That covers five failed get_job polls in a row, the 10-minute deadline, and a job the polled node doesn't have. Studio says the import may still be running or may have finished, and points to the table and the Jobs tab.

One case in there is a real failure that Studio reports as unknown. The job reaches ERROR on the server between Studio's last good poll and the five failed ones. Studio never reads the ERROR, so it can't call the import failed. That part is by design: Studio can't report an outcome it never observed. #1955 records it in src/features/instance/databases/DESIGN.md.

Possible improvement

Once Studio can reach the instance again, it could check that job once more and replace the unknown outcome with the real one. It would say that the import completed, or that it failed with the job's message. That could happen the next time the import dialog or table is opened, or on a slow background check while the page stays open.

The catch: get_job reads only the node it reaches, because hdb_job doesn't replicate. So on a cluster, a recheck can miss the job just as the original polls did. A recheck that doesn't find the job should leave the outcome unknown, never turn it into a failure.

Low priority. The current outcome is honest, and the user is already told to check the table before importing again.

Review-Deferral: 1ebd2884610ec52c severity=nit category=correctness

Raised by the cross-model review of #1955 (#1939).

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lingua principale
TypeScript
Stelle
5
Fork
4
Merge medio
1g 19h
PR unite (30g)
144

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/studio

Tutte le issue di HarperFast/studio

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.