Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

user-client and admin-client are on different major versions of react-query, zustand, and mui-icons

オープン
  • 何か問題がありますか？
#893 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
リファクタリング
明瞭さ
おおむね明確
活発さ
静か
技術スタック
react, typescript
領域
developer-experience, frontend

調査の方向性

Start by comparing the dependency declarations and lockfile entries for user-client and admin-client; the issue does not name their manifest paths. First, assess the @mui/icons-material v5-to-v6 bump in admin-client, then inspect state and data-fetching usage before attempting the other upgrades. Done means the chosen package versions are aligned across clients and the affected client builds and tests pass.

索引モデルが issue の本文から書いたものです。

説明

admin-client question tech debt user-client
Background

While setting up locally I noticed user-client and admin-client each carry their own node_modules folders (177 MB and 58 MB) while backend, common, and integrations do not.

The cause is that the two clients depend on different major versions of a few shared packages:

Package user-client admin-client
@tanstack/react-query ^5.56.2 ^4.10.1
zustand ^4.5.5 ^5.0.0
@mui/icons-material ^6.0.2 ^5.8.3

Yarn (with the node-modules linker declared in .yarnrc.yml) can only hoist one version of a given package to root. When workspaces disagree on the major version, one wins the root spot and the other gets a local copy in its own node_modules.

Nothing is broken today. Each workspace's imports resolve to the correct version via node's module resolution, and the two clients never share objects at runtime.

Problem

The two clients already share a substantial base: React 18, @mui/material v6.1.5, @emotion/react / @emotion/styled, react-hook-form v7, react-router-dom v6, immer v10. The three drifted packages sit directly on top of this shared foundation. Aligning them would give three concrete benefits:

  • Maintenance surface will keep growing. React Query v4 is essentially in maintenance mode. Security patches will taper off, adding to the same package-vulnerability churn flagged in #872.
  • Blocks shared React code in common. Because the underlying stack is already aligned, any shared React component, hook, or state helper could be extracted into common for reuse across both frontends. The current drift on these three specific packages blocks that.
  • API knowledge overhead. Anyone maintaining both frontends has to remember two API generations per library. React Query v4 → v5 in particular has meaningfully different syntax (object-syntax hooks, placeholderData replacing keepPreviousData, changed filter callbacks).
Proposed approach

Rather than a big-bang alignment project, do the migrations opportunistically as each area is touched. Ordered from lowest effort:

  • Bump @mui/icons-material in admin-client from v5 to v6. Trivial (icons are SVG components, near-zero API surface). Bonus: admin-client is already on @mui/material v6.1.5, so the current v5 icons combo is arguably an inconsistency worth fixing anyway.
  • Bump zustand in user-client from v4 to v5 next time someone touches user-client's state layer. Largely backward compatible.
  • Bump @tanstack/react-query in admin-client from v4 to v5 next time someone touches admin-client's data-fetching layer. Non-trivial — every useQuery / useMutation call needs review.

Alternatively, if the team prefers to knock all three out as one small tech-debt task, that also works.

主要言語
TypeScript
スター
4
フォーク
0
平均マージ
14時間 50分
マージ済み PR（30日）
5

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Garvan-Data-Science-Platform/ctrl のほかの issue

Garvan-Data-Science-Platform/ctrl の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。