user-client and admin-client are on different major versions of react-query, zustand, and mui-icons
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 48/100
- Issue-Typ
- Refactoring
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Ruhig
- Tech-Stack
- react, typescript
- Bereich
- developer-experience, frontend
Rechercherichtung
Start by comparing the dependency declarations and lockfile entries for user-client and admin-client; the issue does not name their manifest paths. First, assess the @mui/icons-material v5-to-v6 bump in admin-client, then inspect state and data-fetching usage before attempting the other upgrades. Done means the chosen package versions are aligned across clients and the affected client builds and tests pass.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Background
While setting up locally I noticed user-client and admin-client each carry their own node_modules folders (177 MB and 58 MB) while backend, common, and integrations do not.
The cause is that the two clients depend on different major versions of a few shared packages:
| Package | user-client | admin-client |
|---|---|---|
@tanstack/react-query |
^5.56.2 |
^4.10.1 |
zustand |
^4.5.5 |
^5.0.0 |
@mui/icons-material |
^6.0.2 |
^5.8.3 |
Yarn (with the node-modules linker declared in .yarnrc.yml) can only hoist one version of a given package to root. When workspaces disagree on the major version, one wins the root spot and the other gets a local copy in its own node_modules.
Nothing is broken today. Each workspace's imports resolve to the correct version via node's module resolution, and the two clients never share objects at runtime.
Problem
The two clients already share a substantial base: React 18, @mui/material v6.1.5, @emotion/react / @emotion/styled, react-hook-form v7, react-router-dom v6, immer v10. The three drifted packages sit directly on top of this shared foundation. Aligning them would give three concrete benefits:
- Maintenance surface will keep growing. React Query v4 is essentially in maintenance mode. Security patches will taper off, adding to the same package-vulnerability churn flagged in #872.
- Blocks shared React code in
common. Because the underlying stack is already aligned, any shared React component, hook, or state helper could be extracted intocommonfor reuse across both frontends. The current drift on these three specific packages blocks that. - API knowledge overhead. Anyone maintaining both frontends has to remember two API generations per library. React Query v4 → v5 in particular has meaningfully different syntax (object-syntax hooks,
placeholderDatareplacingkeepPreviousData, changed filter callbacks).
Proposed approach
Rather than a big-bang alignment project, do the migrations opportunistically as each area is touched. Ordered from lowest effort:
- Bump
@mui/icons-materialin admin-client from v5 to v6. Trivial (icons are SVG components, near-zero API surface). Bonus: admin-client is already on@mui/materialv6.1.5, so the current v5 icons combo is arguably an inconsistency worth fixing anyway. - Bump
zustandin user-client from v4 to v5 next time someone touches user-client's state layer. Largely backward compatible. - Bump
@tanstack/react-queryin admin-client from v4 to v5 next time someone touches admin-client's data-fetching layer. Non-trivial — everyuseQuery/useMutationcall needs review.
Alternatively, if the team prefers to knock all three out as one small tech-debt task, that also works.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 4
- Forks
- 0
- Ø Merge
- 14 Std. 50 Min.
- Gemergte PRs (30 T.)
- 5
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus Garvan-Data-Science-Platform/ctrl
-
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 82/100
-
admin-client backend bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
-
backend bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Garvan-Data-Science-Platform/ctrl#970 · 1 Kommentar ·
-
backend bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
-
backend bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Alle Issues in Garvan-Data-Science-Platform/ctrl
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
apache/rocketmq-dashboard#6872 ·
Maintainer antworten meist innerhalb von 3 Tagen
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
fab-geocommuns/RNB-site#539 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Guest multiview tile label leaks raw virtual-source-id "Whip" instead of the guest name / slot labelOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
Eyevinn/open-live-studio#211 ·
Maintainer antworten meist innerhalb von 1 Tag
-
documentation good first issue
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 72/100
sujithputta02/Esapay#13 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
ehmpathy/rhachet-roles-bhuild#468 ·
Maintainer antworten meist innerhalb von 1 Tag