ENH: Retire unchecked paths in shared image engines

オープン
#1,985 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 6 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp
領域
backend, data

調査の方向性

Start by reviewing the finite-difference and recursive Gaussian image engines, the checked paths for Curvature Flow and Smoothing Recursive Gaussian, and PR #1888's review discussion; the issue does not name file paths or tests. Trace how successful transfer warnings and later failures are handled, then compare affected filter results in in-core and out-of-core modes, including outputs, precision, cancellation, and diagnostics. Done means warnings are retained in order, the original failure is preserved, and the legacy unchecked modes are retired only after the numerical contracts are verified.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Summary

Retire the unchecked paths in the finite-difference and recursive Gaussian image engines. Successful read or write operations can return warnings. Some default engine paths discard those warnings when they check only for errors. The checked paths added for Curvature Flow and Smoothing Recursive Gaussian retain diagnostics.

Start with warning propagation. Then confirm the numerical contracts for the sibling filters before removing the legacy conversion paths. The mode switches also affect numeric narrowing, so review this migration against existing filter results.

Acceptance criteria

  • Keep each successful transfer warning once, including when a later transfer fails. Preserve the original failure and verify the diagnostic order with a test store that emits distinct warnings.
  • Verify the affected filters in both in-core and out-of-core configurations. Check outputs, precision, cancellation, and diagnostics before retiring the unchecked modes.
  • Keep filter-specific diagnostics at their callers and apply the coding knowledge base rule on Result handling.

Related work

PR #1888 review identified these engine paths. #1868 inventories other dropped results. #1929 evaluates the cost of retaining repeated transfer warnings.

主要言語
C++
スター
18
フォーク
15
平均マージ
4日 23時間
マージ済み PR(30日)
42

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

BlueQuartzSoftware/simplnx のほかの issue

BlueQuartzSoftware/simplnx の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。