ENH: Retire unchecked paths in shared image engines

Aperta
#1,985 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 6 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
backend, data

Direzione di ricerca

Start by reviewing the finite-difference and recursive Gaussian image engines, the checked paths for Curvature Flow and Smoothing Recursive Gaussian, and PR #1888's review discussion; the issue does not name file paths or tests. Trace how successful transfer warnings and later failures are handled, then compare affected filter results in in-core and out-of-core modes, including outputs, precision, cancellation, and diagnostics. Done means warnings are retained in order, the original failure is preserved, and the legacy unchecked modes are retired only after the numerical contracts are verified.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Summary

Retire the unchecked paths in the finite-difference and recursive Gaussian image engines. Successful read or write operations can return warnings. Some default engine paths discard those warnings when they check only for errors. The checked paths added for Curvature Flow and Smoothing Recursive Gaussian retain diagnostics.

Start with warning propagation. Then confirm the numerical contracts for the sibling filters before removing the legacy conversion paths. The mode switches also affect numeric narrowing, so review this migration against existing filter results.

Acceptance criteria

  • Keep each successful transfer warning once, including when a later transfer fails. Preserve the original failure and verify the diagnostic order with a test store that emits distinct warnings.
  • Verify the affected filters in both in-core and out-of-core configurations. Check outputs, precision, cancellation, and diagnostics before retiring the unchecked modes.
  • Keep filter-specific diagnostics at their callers and apply the coding knowledge base rule on Result handling.

Related work

PR #1888 review identified these engine paths. #1868 inventories other dropped results. #1929 evaluates the cost of retaining repeated transfer warnings.

Lingua principale
C++
Stelle
18
Fork
15
Merge medio
4g 23h
PR unite (30g)
42

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di BlueQuartzSoftware/simplnx

Tutte le issue di BlueQuartzSoftware/simplnx

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.