ENH: Retire unchecked paths in shared image engines

Abierto
#1,985 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 6 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp
Área
backend, data

Línea de trabajo

Start by reviewing the finite-difference and recursive Gaussian image engines, the checked paths for Curvature Flow and Smoothing Recursive Gaussian, and PR #1888's review discussion; the issue does not name file paths or tests. Trace how successful transfer warnings and later failures are handled, then compare affected filter results in in-core and out-of-core modes, including outputs, precision, cancellation, and diagnostics. Done means warnings are retained in order, the original failure is preserved, and the legacy unchecked modes are retired only after the numerical contracts are verified.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Summary

Retire the unchecked paths in the finite-difference and recursive Gaussian image engines. Successful read or write operations can return warnings. Some default engine paths discard those warnings when they check only for errors. The checked paths added for Curvature Flow and Smoothing Recursive Gaussian retain diagnostics.

Start with warning propagation. Then confirm the numerical contracts for the sibling filters before removing the legacy conversion paths. The mode switches also affect numeric narrowing, so review this migration against existing filter results.

Acceptance criteria

  • Keep each successful transfer warning once, including when a later transfer fails. Preserve the original failure and verify the diagnostic order with a test store that emits distinct warnings.
  • Verify the affected filters in both in-core and out-of-core configurations. Check outputs, precision, cancellation, and diagnostics before retiring the unchecked modes.
  • Keep filter-specific diagnostics at their callers and apply the coding knowledge base rule on Result handling.

Related work

PR #1888 review identified these engine paths. #1868 inventories other dropped results. #1929 evaluates the cost of retaining repeated transfer warnings.

Lenguaje dominante
C++
Estrellas
18
Forks
15
Merge medio
4 d 23 h
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BlueQuartzSoftware/simplnx

Todos los issues de BlueQuartzSoftware/simplnx

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.