Rule-based glyph error outline is hue-only; red status text below 4.5:1 (#1605 audit D4, S8)

Aperta
  • Qualcosa non va?
#2,140 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
85/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
java
Ambito
accessibility

Direzione di ricerca

Start with the accessible error-text color added to GuiConstants by the #1605 remediation, then replace Color.red in StructureMappingTableRenderer, MathOverridesPanel, MultiPurposeTextPanel, DefaultScrollTableCellRenderer:126, DefineROI_SummaryPanel and NumericsTestCellRenderer. For D4, edit the error-state outline branch in vcell-core/.../cbit/vcell/graph/MolecularTypeLargeShape.java (lines ~666-690) so error differs by stroke width or a glyph, not only Color.red.darker(). Done when the rg command in Acceptance returns no matches and the outline check passes; optionally read docs/accessibility/color-audit.md (branch docs/1605-color-audit) for rows D4/S8.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Accessibility Requirement Java-based User Interface

Follow-up from the #1605 color audit, rows D4 and S8 (docs/accessibility/color-audit.md). These are smaller findings the audit surfaced outside the model and results viewer remediation.

D4: error outline on rule-based molecule glyphs is hue-only. In vcell-core/.../cbit/vcell/graph/MolecularTypeLargeShape.java (around lines 666–690), a molecule with errors is outlined in Color.red.darker() instead of dark gray: 1.43:1 between the two outlines. The same error is listed with an icon in the issue tables, but on the glyph itself only hue changes. Fix: a thicker or dashed outline, or an error glyph, for error state.

S8: red status text below 4.5:1 (WCAG 1.4.3). Each of these already states its meaning in words or bold, so WCAG 1.4.1 is met, but Color.red is 4.00:1 on white and 3.45:1 on #eeeeee:

  • StructureMappingTableRenderer ("Unmapped")
  • MathOverridesPanel ("remove unused parameter overrides" button text)
  • MultiPurposeTextPanel (error line, bold)
  • DefaultScrollTableCellRenderer:126 (changed network-constraint value, bold)
  • DefineROI_SummaryPanel
  • NumericsTestCellRenderer (internal test UI)

Fix: switch them to the accessible error-text color added to GuiConstants by the #1605 remediation.

Acceptance.

  • rg -n "setForeground\((java\.awt\.)?Color\.(red|RED)\)" --type java returns no matches in these files.
  • The D4 error state differs from normal by stroke or glyph, not only hue.

Part of #1603.

Lingua principale
Java
Stelle
140
Fork
35
Merge medio
11h 28m
PR unite (30g)
19

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di virtualcell/vcell

Tutte le issue di virtualcell/vcell

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.