Rule-based glyph error outline is hue-only; red status text below 4.5:1 (#1605 audit D4, S8)

Abierto
  • ¿Algo no está bien?
#2,140 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
85/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
accessibility

Línea de trabajo

Start with the accessible error-text color added to GuiConstants by the #1605 remediation, then replace Color.red in StructureMappingTableRenderer, MathOverridesPanel, MultiPurposeTextPanel, DefaultScrollTableCellRenderer:126, DefineROI_SummaryPanel and NumericsTestCellRenderer. For D4, edit the error-state outline branch in vcell-core/.../cbit/vcell/graph/MolecularTypeLargeShape.java (lines ~666-690) so error differs by stroke width or a glyph, not only Color.red.darker(). Done when the rg command in Acceptance returns no matches and the outline check passes; optionally read docs/accessibility/color-audit.md (branch docs/1605-color-audit) for rows D4/S8.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Accessibility Requirement Java-based User Interface

Follow-up from the #1605 color audit, rows D4 and S8 (docs/accessibility/color-audit.md). These are smaller findings the audit surfaced outside the model and results viewer remediation.

D4: error outline on rule-based molecule glyphs is hue-only. In vcell-core/.../cbit/vcell/graph/MolecularTypeLargeShape.java (around lines 666–690), a molecule with errors is outlined in Color.red.darker() instead of dark gray: 1.43:1 between the two outlines. The same error is listed with an icon in the issue tables, but on the glyph itself only hue changes. Fix: a thicker or dashed outline, or an error glyph, for error state.

S8: red status text below 4.5:1 (WCAG 1.4.3). Each of these already states its meaning in words or bold, so WCAG 1.4.1 is met, but Color.red is 4.00:1 on white and 3.45:1 on #eeeeee:

  • StructureMappingTableRenderer ("Unmapped")
  • MathOverridesPanel ("remove unused parameter overrides" button text)
  • MultiPurposeTextPanel (error line, bold)
  • DefaultScrollTableCellRenderer:126 (changed network-constraint value, bold)
  • DefineROI_SummaryPanel
  • NumericsTestCellRenderer (internal test UI)

Fix: switch them to the accessible error-text color added to GuiConstants by the #1605 remediation.

Acceptance.

  • rg -n "setForeground\((java\.awt\.)?Color\.(red|RED)\)" --type java returns no matches in these files.
  • The D4 error state differs from normal by stroke or glyph, not only hue.

Part of #1603.

Lenguaje dominante
Java
Estrellas
140
Forks
35
Merge medio
17 h 39 min
PR fusionados (30 d)
19

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de virtualcell/vcell

Todos los issues de virtualcell/vcell

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.