RCE via `pickle.loads` on analysis-cache MANIFEST file (`ReadAnalysisCacheFromFS`)

Aperta
  • Qualcosa non va?
#354 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python, tensorflow
Ambito
data-engineering, security

Direzione di ricerca

Read analyzer_cache.py around lines 107, 181, and 359–408, tracing how the MANIFEST and METADATA files are read and deserialized. The issue proposes replacing pickle serialization with JSON or protobuf and bumping the cache version; check existing cache format tests and add coverage for both file paths. Done means cache reads no longer deserialize attacker-controlled pickle data while preserving the documented cache behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

RCE via pickle.loads on analysis-cache MANIFEST file (ReadAnalysisCacheFromFS)

Note: This was reported to Google via the OSS VRP on 2026-10-11 (issue 572481371) and closed as "Won't Fix (Intended Behavior)". Filing here for public transparency so users of shared cache storage are aware of the risk.

Summary

ReadAnalysisCacheFromFS deserialises the cache MANIFEST file with pickle.loads at pipeline-construction time on the driver machine, with no validation or class allowlist. An attacker who can write to the cache directory (shared GCS bucket, NFS, or any writable path) can plant a malicious MANIFEST and achieve arbitrary code execution on every machine that runs a pipeline against that cache — including CI workers and production training hosts.

Affected code — tensorflow-transform

Location Issue
analyzer_cache.py:181 result = pickle.loads(manifest_file_handle.read()) — MANIFEST deserialised on the driver at graph-construction time
analyzer_cache.py:107 pickle.loads on METADATA TFRecords — fires on Beam workers

Taint path

analyzer_cache.py:199    tf.io.gfile.GFile(self._manifest_path, 'rb')
                         ← attacker controls <cache_base_dir>/<dataset_key>/MANIFEST bytes

analyzer_cache.py:359-390  ReadAnalysisCacheFromFS(cache_base_dir, dataset_keys)
                            ← public PTransform, standard documented usage

analyzer_cache.py:400-408  expand() → manifest_file.read()
                            fires on the DRIVER before the pipeline runs

analyzer_cache.py:181      result = pickle.loads(manifest_file_handle.read())   ← SINK 1
analyzer_cache.py:107      pickle.loads on METADATA TFRecords                   ← SINK 2 (workers)

Proof of concept

# Attacker plants a malicious MANIFEST in the shared cache directory
import pickle, os, pathlib

class Exploit:
    def __reduce__(self):
        return (os.system, ("id > /tmp/pwned",))

cache_dir = pathlib.Path("/shared/tft-cache/span-0")
cache_dir.mkdir(parents=True, exist_ok=True)
(cache_dir / "MANIFEST").write_bytes(pickle.dumps(Exploit()))

# Next pipeline run pointing at cache_dir:
#   ReadAnalysisCacheFromFS(...) → pickle.loads → arbitrary code execution

The same __reduce__ payload in a METADATA-00000-of-00001 TFRecord hits the secondary sink in Beam workers.

Impact

Dimension Assessment
Attack vector Network (shared cloud storage)
Attack complexity Low — write a pickle payload to one file
Privileges required Write access to cache directory only
User interaction None — fires automatically on next pipeline run
Scope Driver machine + all Beam workers

In a typical ML platform deployment this means full compromise of the training environment: cloud credentials attached to the compute instance (GCP service account, AWS IAM role), model weights, training data, secrets in environment variables, and the ability to tamper with pipeline outputs.

Why this is not equivalent to loading an untrusted model

TFT's own documentation and TF's SECURITY.md warn that loading untrusted SavedModels is unsafe. Cache files are different — they are infrastructure artifacts written by one pipeline run and read by the next, often across team boundaries on shared GCS storage. Users have no reason to expect pickle.loads when reading a pipeline cache.

Fix

The MANIFEST is a simple dict[str, str]. Replace pickle with JSON or protobuf — both sinks disappear with no semantic change to the cache format. A cache-version bump handles backward compatibility. DatasetCacheMetadata (strings and ints only) is equally trivial to serialise without pickle.

Lingua principale
Python
Stelle
991
Fork
226
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di tensorflow/transform

Tutte le issue di tensorflow/transform

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.