Add an interview mode filter to interview progress

Aperta
  • Qualcosa non va?
#617 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
html, javascript, rust
Ambito
frontend, testing

Direzione di ricerca

Start with web/progress.js and the existing problemId filter tests in tests/browser/progress.test.js; then trace the filter wiring in web/app.js and the Filter attempts controls in web/index.html. Add mode filtering to the progress model and cover the UI behavior for account and device history in tests/browser/lobby.test.js. Done when Coding, Whiteboard, and All modes filter the attempts and related progress views, including when combined with existing filters.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Observed behavior

Interview progress's "Filter attempts" section offers Problem, Difficulty, Language, and Duration filters (web/index.html:2041-2067), but no filter for interview mode. A Coding (editor) attempt and a Whiteboard attempt sit mixed together in Past attempts and the phase-score charts, even though they score different things (a whiteboard report scores "Board work", not "Coding", per the row labels in #604) and use an unrelated workflow: no editor, no code, no test runner.

Expected behavior

Candidates should be able to restrict Interview progress to only Coding attempts or only Whiteboard attempts. The selection should combine with the existing Problem, Difficulty, Language and Duration filters, and apply consistently to Past attempts, the phase-score charts, topic counts, and weakness summaries, the same way the existing filters already do. Selecting "All modes" should restore the current, unfiltered behavior.

Reproduction

  1. Complete at least one Coding-mode interview and one Whiteboard-mode interview.
  2. Open Interview progress.
  3. Observe that Filter attempts has no control to separate the two; Past attempts and the charts mix both kinds of attempt together.

Environment

  • Source revision: 628237f.

Initial analysis

  • normalizeProgressEntry() in web/progress.js already reads and normalizes interviewMode per attempt (entry.interviewMode ?? entry.report?.interviewMode, through lib.js's interviewMode()), so the value is already present on every normalized entry; no storage or server change is needed.
  • progressModelFrom()'s matches(entry, key) helper (web/progress.js:178-189) already applies one generic filter to problemId, difficulty, language and durationMin; adding "interviewMode" to that list follows the same one-line pattern as each existing filter.
  • progressOptions() (web/progress.js:307-337) would need to also return the distinct interviewMode values present in history, the same way it already does for difficulty, language and durationMin.
  • web/index.html's Filter attempts fieldset (web/index.html:2041-2067) would need one more <select>, alongside Problem/Difficulty/Language/Duration.
  • web/app.js wires each existing <select> through syncFilter() and folds its value into the filters object passed to progressModelFrom() (web/app.js:1925-1943, 2607-2612); a Mode select would follow the same wiring, using lib.js's existing interviewMode()/modeIsWhiteboard() helpers for the two option labels ("Coding", "Whiteboard").

This mirrors the Problem filter added by #389 (PR #501, commit cb6678a), which used this same four-piece pattern (progressOptions, progressModelFrom's matches, the fieldset markup, and app.js's syncFilter wiring) for a different field.

Proposed change

Add a Mode select to Filter attempts, defaulting to "All modes", with "Coding" and "Whiteboard" options sourced from saved history. Combine it with the existing Problem, Difficulty, Language and Duration filters in progressModelFrom(). Apply the resulting attempts consistently to Past attempts, the phase-score charts, topic counts, weakness summaries, and the attempt count. Refresh the options when history changes; a mode with no remaining attempts drops out of the options the same way other filter values already do.

Validation plan

  • Add model regression tests in tests/browser/progress.test.js for interviewMode filtering alone and combined with the existing filters, mirroring the problemId tests already there.
  • Add UI interaction coverage in tests/browser/lobby.test.js for both account and device history, selecting "Coding" / "Whiteboard" / "All modes" and asserting Past attempts and the charts narrow accordingly, mirroring the existing #progress-language coverage.
  • Run ./scripts/test.sh and report results, including anything skipped.
Lingua principale
Rust
Stelle
223
Fork
148
Merge medio
1g 7h
PR unite (30g)
225

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sysprog21/codetrial

Tutte le issue di sysprog21/codetrial

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.