Add an interview mode filter to interview progress

オープン
  • 何か問題がありますか？
#617 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
78/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
html, javascript, rust
領域
frontend, testing

調査の方向性

Start with web/progress.js and the existing problemId filter tests in tests/browser/progress.test.js; then trace the filter wiring in web/app.js and the Filter attempts controls in web/index.html. Add mode filtering to the progress model and cover the UI behavior for account and device history in tests/browser/lobby.test.js. Done when Coding, Whiteboard, and All modes filter the attempts and related progress views, including when combined with existing filters.

索引モデルが issue の本文から書いたものです。

説明

Observed behavior

Interview progress's "Filter attempts" section offers Problem, Difficulty, Language, and Duration filters (web/index.html:2041-2067), but no filter for interview mode. A Coding (editor) attempt and a Whiteboard attempt sit mixed together in Past attempts and the phase-score charts, even though they score different things (a whiteboard report scores "Board work", not "Coding", per the row labels in #604) and use an unrelated workflow: no editor, no code, no test runner.

Expected behavior

Candidates should be able to restrict Interview progress to only Coding attempts or only Whiteboard attempts. The selection should combine with the existing Problem, Difficulty, Language and Duration filters, and apply consistently to Past attempts, the phase-score charts, topic counts, and weakness summaries, the same way the existing filters already do. Selecting "All modes" should restore the current, unfiltered behavior.

Reproduction

  1. Complete at least one Coding-mode interview and one Whiteboard-mode interview.
  2. Open Interview progress.
  3. Observe that Filter attempts has no control to separate the two; Past attempts and the charts mix both kinds of attempt together.

Environment

  • Source revision: 628237f.

Initial analysis

  • normalizeProgressEntry() in web/progress.js already reads and normalizes interviewMode per attempt (entry.interviewMode ?? entry.report?.interviewMode, through lib.js's interviewMode()), so the value is already present on every normalized entry; no storage or server change is needed.
  • progressModelFrom()'s matches(entry, key) helper (web/progress.js:178-189) already applies one generic filter to problemId, difficulty, language and durationMin; adding "interviewMode" to that list follows the same one-line pattern as each existing filter.
  • progressOptions() (web/progress.js:307-337) would need to also return the distinct interviewMode values present in history, the same way it already does for difficulty, language and durationMin.
  • web/index.html's Filter attempts fieldset (web/index.html:2041-2067) would need one more <select>, alongside Problem/Difficulty/Language/Duration.
  • web/app.js wires each existing <select> through syncFilter() and folds its value into the filters object passed to progressModelFrom() (web/app.js:1925-1943, 2607-2612); a Mode select would follow the same wiring, using lib.js's existing interviewMode()/modeIsWhiteboard() helpers for the two option labels ("Coding", "Whiteboard").

This mirrors the Problem filter added by #389 (PR #501, commit cb6678a), which used this same four-piece pattern (progressOptions, progressModelFrom's matches, the fieldset markup, and app.js's syncFilter wiring) for a different field.

Proposed change

Add a Mode select to Filter attempts, defaulting to "All modes", with "Coding" and "Whiteboard" options sourced from saved history. Combine it with the existing Problem, Difficulty, Language and Duration filters in progressModelFrom(). Apply the resulting attempts consistently to Past attempts, the phase-score charts, topic counts, weakness summaries, and the attempt count. Refresh the options when history changes; a mode with no remaining attempts drops out of the options the same way other filter values already do.

Validation plan

  • Add model regression tests in tests/browser/progress.test.js for interviewMode filtering alone and combined with the existing filters, mirroring the problemId tests already there.
  • Add UI interaction coverage in tests/browser/lobby.test.js for both account and device history, selecting "Coding" / "Whiteboard" / "All modes" and asserting Past attempts and the charts narrow accordingly, mirroring the existing #progress-language coverage.
  • Run ./scripts/test.sh and report results, including anything skipped.
主要言語
Rust
スター
223
フォーク
148
平均マージ
1日 7時間
マージ済み PR（30日）
225

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

sysprog21/codetrial のほかの issue

sysprog21/codetrial の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。