Keep from xx import yy style when moving

Aperta
  • Qualcosa non va?
#694 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 7 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
22/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
python
Ambito
tooling

Direzione di ricerca

The move logic is in rope/refactor/move.py: the reporter's experiment changes _new_import, which builds the import for the destination, and the new_name assignment near line 571. Start by reading how the moved module's old and new names are used there. Their own patch breaks when the source module is nested deeper than one level (for example A.C moved to B.D.C), so a working version must handle that case. Done means a move keeps the from-import style for both shallow and nested modules, with no leftover bare imports. The thread has no maintainer response, so the design should be agreed before writing code.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

When I try to use rope as a libaray to move module A.C to B.C, I found that code like "from A.C import foo;foo()" will be changed to "A.C.foo()", which will extremely enlarge my code when foo is in modulde like "from A.C.D.E.G"

I want to keep my origin style like "from B.C import foo;foo()", which only change import statment

After single debug and read the source code, I think the core control of such case may in rope.refactor.move，replace from NormalImport to FromImport may works?

I actually just attempted to make the following modifications :

# in https://github.com/python-rope/rope/blob/master/rope/refactor/move.py#L553
    def _new_import(self, dest):
        # origin code
        # return importutils.NormalImport([(self._new_modname(dest), None)])
        # What I changed
        return importutils.FromImport(libutils.modname(dest),0, [(self.old_name, None)])

# in https://github.com/python-rope/rope/blob/master/rope/refactor/move.py#L571
        # origin code
        # new_name = self._new_modname(dest)
        # What I changed
        new_name = self.old_name

when I run it on my project, it seems work only when src module`s deepth is 1,when src module is like A.C
move will change the code in wrong way like:

a.py
import A.C

move A.C -> B.D.C

a.py
import C
from B.D import C

May I request the project team to include this feature as a new feature in the project? Thank you for your work and effort.

Lingua principale
Python
Stelle
2.2k
Fork
197
Merge medio
2g 13h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di python-rope/rope

Tutte le issue di python-rope/rope

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.