Keep from xx import yy style when moving

Aberta
  • Algo errado?
#694 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 7 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
22/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
python
Domínio
tooling

Direção de pesquisa

The move logic is in rope/refactor/move.py: the reporter's experiment changes _new_import, which builds the import for the destination, and the new_name assignment near line 571. Start by reading how the moved module's old and new names are used there. Their own patch breaks when the source module is nested deeper than one level (for example A.C moved to B.D.C), so a working version must handle that case. Done means a move keeps the from-import style for both shallow and nested modules, with no leftover bare imports. The thread has no maintainer response, so the design should be agreed before writing code.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

When I try to use rope as a libaray to move module A.C to B.C, I found that code like "from A.C import foo;foo()" will be changed to "A.C.foo()", which will extremely enlarge my code when foo is in modulde like "from A.C.D.E.G"

I want to keep my origin style like "from B.C import foo;foo()", which only change import statment

After single debug and read the source code, I think the core control of such case may in rope.refactor.move，replace from NormalImport to FromImport may works?

I actually just attempted to make the following modifications :

# in https://github.com/python-rope/rope/blob/master/rope/refactor/move.py#L553
    def _new_import(self, dest):
        # origin code
        # return importutils.NormalImport([(self._new_modname(dest), None)])
        # What I changed
        return importutils.FromImport(libutils.modname(dest),0, [(self.old_name, None)])

# in https://github.com/python-rope/rope/blob/master/rope/refactor/move.py#L571
        # origin code
        # new_name = self._new_modname(dest)
        # What I changed
        new_name = self.old_name

when I run it on my project, it seems work only when src module`s deepth is 1,when src module is like A.C
move will change the code in wrong way like:

a.py
import A.C

move A.C -> B.D.C

a.py
import C
from B.D import C

May I request the project team to include this feature as a new feature in the project? Thank you for your work and effort.

Linguagem predominante
Python
Estrelas
2.2k
Forks
197
Merge médio
2d 13h
PRs com merge (30d)
5

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de python-rope/rope

Todas as issues de python-rope/rope

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.