GLPI 12: 11 reports fail with "Ocorreu um erro inesperado" (subquery params lost in QueryExpression, QueryUnion passed to request(), empty IN)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 74/100
Direzione di ricerca
Start with inc/inventory.class.php: the issue identifies seven QueryExpression percentage subqueries and two reports passing QueryUnion directly to $DB->request(). Then inspect the second request in inc/helpdeskplus.class.php for the empty category list in reportHgbarRespectedSlasByTopCategory. Reproduce the three failures on GLPI 12 and verify the bundled reports open without errors and their percentages match direct SQL counts.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
With GLPI 12.0.1 and mreporting 1.11.0 / 1.11.1, 11 of the bundled reports end on the GLPI error page. We opened every report of the plugin (Helpdesk, Helpdesk advanced, Inventory, Tag): the Helpdesk and Tag reports work. The broken ones are 10 Inventory reports and 1 Helpdesk advanced report. There are three different causes, all related to GLPI 12 executing queries as prepared statements.
1. Percentage subquery loses its parameters (6 Inventory reports)
reportPie/HbarComputersByFabricant, reportPie/HbarComputersByType, reportHbarComputersByStatus, reportHbarPrintersByStatus:
Number of placeholders (6) in SQL statement does not match number of values (3).
The percentage is built as:
new QueryExpression("COUNT(*) * 100 / " . new QuerySubQuery($subquery, 'Percent'))
Casting the QuerySubQuery to a string keeps the ? placeholders of the subquery, but its values are not carried over, so the statement has more placeholders than values. In GLPI 12, QueryExpression has a third $values argument, so the parameters can be passed along:
$sub = new QuerySubQuery($subquery, 'Percent');
new QueryExpression('COUNT(*) * 100 / ' . $sub, null, $sub->getParams());
There are 7 occurrences in inc/inventory.class.php (same code in master).
2. QueryUnion passed directly to $DB->request() (4 Inventory reports)
reportPie/HbarComputersByAge, reportPie/HbarComputersByOS:
TypeError: DBmysqlIterator::execute(): Argument #1 ($criteria) must be of type array, Glpi\DBAL\QueryUnion given
inc/inventory.class.php:386 (computersByAge), inc/inventory.class.php:525 (computersByOS)
GLPI 12 only accepts an array here. Using the union as FROM works, as the core does (for example Lockedfield.php):
$query = new QueryUnion($queries);
$result = $DB->request(['FROM' => $query]);
These queries also contain the percentage subquery from point 1.
3. Empty IN when no ticket has an SLA (1 Helpdesk advanced report)
reportHgbarRespectedSlasByTopCategory:
RuntimeException: Empty IN are not allowed
inc/helpdeskplus.class.php (second $DB->request() of reportHgbarRespectedSlasByTopCategory)
When no category is selected and no ticket has an SLA, $categories is empty and is used as ITILCategory::getTable() . '.id' => $categories. Returning the empty result before the second query avoids the error, for example:
if (!$category && $categories === []) {
return ['labels2' => [$this->lcl_slaok => $this->lcl_slaok, $this->lcl_slako => $this->lcl_slako]];
}
Result
With these three changes applied locally on 1.11.1, all reports of the plugin open without error, nothing new is logged, and the percentages are the same as a direct SQL count (checked on "Computers by manufacturer").
Side note, not an error: in the Inventory reports the total used for the percentage (the subquery) does not filter is_deleted = 0, while the counted rows do. When items are in the trash, the percentages do not add up to 100 %.
Environment
- GLPI 12.0.1
- mreporting 1.11.0 and 1.11.1 (same code for these parts in
master) - PHP 8.4.27, MariaDB 11.8.6, Debian 13
- Lingua principale
- PHP
- Stelle
- 38
- Fork
- 44
- Merge medio
- 10h 52m
- PR unite (30g)
- 8
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
pluginsGLPI/carbon#396 ·
-
[BUG] Bundle products lose their price in RSS feeds: getPrices() was removedForse già presa @pcvelz l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
OpenMage/magento-lts#5869 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 85/100
modelcontextprotocol/php-sdk#746 ·
I maintainer di solito rispondono entro 1 giorno
-
Map Info Window ButtonsAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
OpenGIS/waymark-wp#82 ·
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno