GLPI 12: 11 reports fail with "Ocorreu um erro inesperado" (subquery params lost in QueryExpression, QueryUnion passed to request(), empty IN)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 74/100
Línea de trabajo
Start with inc/inventory.class.php: the issue identifies seven QueryExpression percentage subqueries and two reports passing QueryUnion directly to $DB->request(). Then inspect the second request in inc/helpdeskplus.class.php for the empty category list in reportHgbarRespectedSlasByTopCategory. Reproduce the three failures on GLPI 12 and verify the bundled reports open without errors and their percentages match direct SQL counts.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
With GLPI 12.0.1 and mreporting 1.11.0 / 1.11.1, 11 of the bundled reports end on the GLPI error page. We opened every report of the plugin (Helpdesk, Helpdesk advanced, Inventory, Tag): the Helpdesk and Tag reports work. The broken ones are 10 Inventory reports and 1 Helpdesk advanced report. There are three different causes, all related to GLPI 12 executing queries as prepared statements.
1. Percentage subquery loses its parameters (6 Inventory reports)
reportPie/HbarComputersByFabricant, reportPie/HbarComputersByType, reportHbarComputersByStatus, reportHbarPrintersByStatus:
Number of placeholders (6) in SQL statement does not match number of values (3).
The percentage is built as:
new QueryExpression("COUNT(*) * 100 / " . new QuerySubQuery($subquery, 'Percent'))
Casting the QuerySubQuery to a string keeps the ? placeholders of the subquery, but its values are not carried over, so the statement has more placeholders than values. In GLPI 12, QueryExpression has a third $values argument, so the parameters can be passed along:
$sub = new QuerySubQuery($subquery, 'Percent');
new QueryExpression('COUNT(*) * 100 / ' . $sub, null, $sub->getParams());
There are 7 occurrences in inc/inventory.class.php (same code in master).
2. QueryUnion passed directly to $DB->request() (4 Inventory reports)
reportPie/HbarComputersByAge, reportPie/HbarComputersByOS:
TypeError: DBmysqlIterator::execute(): Argument #1 ($criteria) must be of type array, Glpi\DBAL\QueryUnion given
inc/inventory.class.php:386 (computersByAge), inc/inventory.class.php:525 (computersByOS)
GLPI 12 only accepts an array here. Using the union as FROM works, as the core does (for example Lockedfield.php):
$query = new QueryUnion($queries);
$result = $DB->request(['FROM' => $query]);
These queries also contain the percentage subquery from point 1.
3. Empty IN when no ticket has an SLA (1 Helpdesk advanced report)
reportHgbarRespectedSlasByTopCategory:
RuntimeException: Empty IN are not allowed
inc/helpdeskplus.class.php (second $DB->request() of reportHgbarRespectedSlasByTopCategory)
When no category is selected and no ticket has an SLA, $categories is empty and is used as ITILCategory::getTable() . '.id' => $categories. Returning the empty result before the second query avoids the error, for example:
if (!$category && $categories === []) {
return ['labels2' => [$this->lcl_slaok => $this->lcl_slaok, $this->lcl_slako => $this->lcl_slako]];
}
Result
With these three changes applied locally on 1.11.1, all reports of the plugin open without error, nothing new is logged, and the percentages are the same as a direct SQL count (checked on "Computers by manufacturer").
Side note, not an error: in the Inventory reports the total used for the percentage (the subquery) does not filter is_deleted = 0, while the counted rows do. When items are in the trash, the percentages do not add up to 100 %.
Environment
- GLPI 12.0.1
- mreporting 1.11.0 and 1.11.1 (same code for these parts in
master) - PHP 8.4.27, MariaDB 11.8.6, Debian 13
- Lenguaje dominante
- PHP
- Estrellas
- 38
- Forks
- 44
- Merge medio
- 10 h 52 min
- PR fusionados (30 d)
- 8
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
pluginsGLPI/carbon#396 ·
-
[BUG] Bundle products lose their price in RSS feeds: getPrices() was removedPosiblemente ocupada @pcvelz la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
OpenMage/magento-lts#5869 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 85/100
modelcontextprotocol/php-sdk#746 ·
Los mantenedores suelen responder en 1 día
-
Map Info Window ButtonsAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
OpenGIS/waymark-wp#82 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día