GLPI 12: 11 reports fail with "Ocorreu um erro inesperado" (subquery params lost in QueryExpression, QueryUnion passed to request(), empty IN)

Ouverte
#409 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
74/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
php
Domaine
backend

Piste de recherche

Start with inc/inventory.class.php: the issue identifies seven QueryExpression percentage subqueries and two reports passing QueryUnion directly to $DB->request(). Then inspect the second request in inc/helpdeskplus.class.php for the empty category list in reportHgbarRespectedSlasByTopCategory. Reproduce the three failures on GLPI 12 and verify the bundled reports open without errors and their percentages match direct SQL counts.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Description

With GLPI 12.0.1 and mreporting 1.11.0 / 1.11.1, 11 of the bundled reports end on the GLPI error page. We opened every report of the plugin (Helpdesk, Helpdesk advanced, Inventory, Tag): the Helpdesk and Tag reports work. The broken ones are 10 Inventory reports and 1 Helpdesk advanced report. There are three different causes, all related to GLPI 12 executing queries as prepared statements.

1. Percentage subquery loses its parameters (6 Inventory reports)

reportPie/HbarComputersByFabricant, reportPie/HbarComputersByType, reportHbarComputersByStatus, reportHbarPrintersByStatus:

Number of placeholders (6) in SQL statement does not match number of values (3).

The percentage is built as:

new QueryExpression("COUNT(*) * 100 / " . new QuerySubQuery($subquery, 'Percent'))

Casting the QuerySubQuery to a string keeps the ? placeholders of the subquery, but its values are not carried over, so the statement has more placeholders than values. In GLPI 12, QueryExpression has a third $values argument, so the parameters can be passed along:

$sub = new QuerySubQuery($subquery, 'Percent');
new QueryExpression('COUNT(*) * 100 / ' . $sub, null, $sub->getParams());

There are 7 occurrences in inc/inventory.class.php (same code in master).

2. QueryUnion passed directly to $DB->request() (4 Inventory reports)

reportPie/HbarComputersByAge, reportPie/HbarComputersByOS:

TypeError: DBmysqlIterator::execute(): Argument #1 ($criteria) must be of type array, Glpi\DBAL\QueryUnion given
inc/inventory.class.php:386 (computersByAge), inc/inventory.class.php:525 (computersByOS)

GLPI 12 only accepts an array here. Using the union as FROM works, as the core does (for example Lockedfield.php):

$query  = new QueryUnion($queries);
$result = $DB->request(['FROM' => $query]);

These queries also contain the percentage subquery from point 1.

3. Empty IN when no ticket has an SLA (1 Helpdesk advanced report)

reportHgbarRespectedSlasByTopCategory:

RuntimeException: Empty IN are not allowed
inc/helpdeskplus.class.php (second $DB->request() of reportHgbarRespectedSlasByTopCategory)

When no category is selected and no ticket has an SLA, $categories is empty and is used as ITILCategory::getTable() . '.id' => $categories. Returning the empty result before the second query avoids the error, for example:

if (!$category && $categories === []) {
    return ['labels2' => [$this->lcl_slaok => $this->lcl_slaok, $this->lcl_slako => $this->lcl_slako]];
}
Result

With these three changes applied locally on 1.11.1, all reports of the plugin open without error, nothing new is logged, and the percentages are the same as a direct SQL count (checked on "Computers by manufacturer").

Side note, not an error: in the Inventory reports the total used for the percentage (the subquery) does not filter is_deleted = 0, while the counted rows do. When items are in the trash, the percentages do not add up to 100 %.

Environment
  • GLPI 12.0.1
  • mreporting 1.11.0 and 1.11.1 (same code for these parts in master)
  • PHP 8.4.27, MariaDB 11.8.6, Debian 13
Langage dominant
PHP
Étoiles
38
Forks
44
Merge moyen
10 h 52 min
PR mergées (30 j)
8

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Issues similaires

Plus d'issues PHP

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.