[Testing] Test downstream plugins that load SQL classes (alerting, skills)

Aperta
  • Qualcosa non va?
#5,925 1 commento 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@ahkcs ci sta già lavorando.

Dal 3/11/2026.

  • #5926 di @ig-suyas — aperta

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
18/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java
Ambito
testing-qa

Direzione di ricerca

Start with ThinJarClassesTest and the thin-jar build for the SQL plugin, then read PPLQueryAction, TransportPPLQueryRequest, TransportPPLQueryResponse and PPLQueryTask to see what consumers load. The work is a CI task that installs alerting with a rebuilt thin jar and runs a PPL monitor, plus an isolated classloader check that fails on LinkageError. Done means both checks run in CI and would have caught the NoClassDefFoundError in #5923.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

infrastructure testing
Problem

Our unit and integration tests check that SQL/PPL works on its own. They don't check the plugins that load SQL classes directly, so a change can pass all of our CI and still break them.

That happened in 3.10.0: #5910 added an opensearch-module interface to PPLQueryTask. All SQL CI passed, but every PPL alerting monitor crashed the node with NoClassDefFoundError (#5923, fixed in #5924). It was found in Observability stack testing, near code freeze.

Why our tests miss this
  • Alerting and skills call PPLQueryAction using their own opensearch-sql-thin jar. They build it from our plugin classes plus the core, ppl, and protocol jars, and it does not include the opensearch module. Their classloader therefore sees only part of our code.
  • Our ITs run with the whole SQL plugin on one classpath, so a class that is fine for us but broken for them always passes.
  • #5924 added ThinJarClassesTest. It only checks the four classes we know alerting loads, by reflection, so it would miss a new class or a new consumer.
Proposal
  1. Consumer smoke IT. Add a CI task that installs alerting (and skills, if practical) with its thin jar rebuilt from the current SQL build, then runs a PPL monitor create, an _execute, and a scheduled run, and checks that the node stays up. This would have caught #5923 before merge.
  2. Isolated classloader check. Build a thin jar the way alerting does. Load the consumer-facing classes in a classloader that holds only that jar plus core/ppl/protocol and OpenSearch, and fail on any LinkageError. This is stricter than the reflection check in ThinJarClassesTest.
  3. Document the consumer surface. List the classes other plugins load: PPLQueryAction, TransportPPLQueryRequest, TransportPPLQueryResponse, PPLQueryTask, and any classes skills uses. Treat them as API, and note in the developer docs that they must not depend on the opensearch module.
  4. Find all consumers. Check which other plugins (alerting, skills, query-insights, others) bundle SQL classes, so the tests above cover all of them.
Related
  • #5923 / #5924: the regression and the fix
  • opensearch-project/alerting#2322: alerting CI failed on the same regression
Lingua principale
Java
Stelle
175
Fork
233
Merge medio
3g 36m
PR unite (30g)
41

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensearch-project/sql

Tutte le issue di opensearch-project/sql

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.