[Testing] Test downstream plugins that load SQL classes (alerting, skills)

Abierto
  • ¿Algo no está bien?
#5,925 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@ahkcs ya está trabajando en esto.

Desde el 3/11/2026.

  • #5926 de @ig-suyas — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
18/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java
Área
testing-qa

Línea de trabajo

Start with ThinJarClassesTest and the thin-jar build for the SQL plugin, then read PPLQueryAction, TransportPPLQueryRequest, TransportPPLQueryResponse and PPLQueryTask to see what consumers load. The work is a CI task that installs alerting with a rebuilt thin jar and runs a PPL monitor, plus an isolated classloader check that fails on LinkageError. Done means both checks run in CI and would have caught the NoClassDefFoundError in #5923.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

infrastructure testing
Problem

Our unit and integration tests check that SQL/PPL works on its own. They don't check the plugins that load SQL classes directly, so a change can pass all of our CI and still break them.

That happened in 3.10.0: #5910 added an opensearch-module interface to PPLQueryTask. All SQL CI passed, but every PPL alerting monitor crashed the node with NoClassDefFoundError (#5923, fixed in #5924). It was found in Observability stack testing, near code freeze.

Why our tests miss this
  • Alerting and skills call PPLQueryAction using their own opensearch-sql-thin jar. They build it from our plugin classes plus the core, ppl, and protocol jars, and it does not include the opensearch module. Their classloader therefore sees only part of our code.
  • Our ITs run with the whole SQL plugin on one classpath, so a class that is fine for us but broken for them always passes.
  • #5924 added ThinJarClassesTest. It only checks the four classes we know alerting loads, by reflection, so it would miss a new class or a new consumer.
Proposal
  1. Consumer smoke IT. Add a CI task that installs alerting (and skills, if practical) with its thin jar rebuilt from the current SQL build, then runs a PPL monitor create, an _execute, and a scheduled run, and checks that the node stays up. This would have caught #5923 before merge.
  2. Isolated classloader check. Build a thin jar the way alerting does. Load the consumer-facing classes in a classloader that holds only that jar plus core/ppl/protocol and OpenSearch, and fail on any LinkageError. This is stricter than the reflection check in ThinJarClassesTest.
  3. Document the consumer surface. List the classes other plugins load: PPLQueryAction, TransportPPLQueryRequest, TransportPPLQueryResponse, PPLQueryTask, and any classes skills uses. Treat them as API, and note in the developer docs that they must not depend on the opensearch module.
  4. Find all consumers. Check which other plugins (alerting, skills, query-insights, others) bundle SQL classes, so the tests above cover all of them.
Related
  • #5923 / #5924: the regression and the fix
  • opensearch-project/alerting#2322: alerting CI failed on the same regression
Lenguaje dominante
Java
Estrellas
175
Forks
236
Merge medio
2 d 19 h
PR fusionados (30 d)
40

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensearch-project/sql

Todos los issues de opensearch-project/sql

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.