Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[v2] e2e `protocol:timeout:max-total` is flaky over SSE: fake timers advance before the request reaches the server

Aperta Adatta ai principianti
  • Qualcosa non va?
#3,045 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Singmin ci sta già lavorando.

Dal 18/10/2026.

  • #3048 di @Singmin — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
testing-qa

Direzione di ricerca

Inizia con le varianti SSE di protocol:timeout:max-total in test/e2e/scenarios/protocol.test.ts e confronta i loro passaggi con i timer simulati con il modello vi.waitFor del test timeout:reset-on-progress. Esegui il comando di riproduzione dell’issue, comprese esecuzioni ripetute, per confermare il fallimento intermittente. Il lavoro è completato quando il test raggiunge in modo affidabile gli eventi di avanzamento del server e SSE segnala Maximum total timeout exceeded come gli altri trasporti.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

v1 v2
What happened?

On macOS, the two SSE variants of protocol:timeout:max-total in test/e2e/scenarios/protocol.test.ts fail intermittently on a clean clone of main. The other transports always pass, and CI on main is green.

AssertionError: expected 0 to be greater than or equal to 3
 ❯ scenarios/protocol.test.ts:713:30

followed by an unhandled SdkError: Request timed out.

The failure rate moves around. On Oct 14 it failed in the full suite and in 3 of 3 isolated runs. On Oct 16, -t "timeout:basic|timeout:max-total" failed 3 of 6 times, while the max-total test on its own passed 6 of 6.

What I think is happening: the test switches to fake timers, starts the call, and immediately advances the clock in 200ms steps. Over SSE, the tools/call request is a real HTTP POST, and the fake clock doesn't wait for it. When the POST is slow to land, the clock is already past the 500ms per-request timeout, so the call rejects with Request timed out before the server sends any progress. In those runs the test never reaches maxTotalTimeout at all.

To check, I added temporary logging of server-sent progress, client-received progress, and each clock step. In failing runs, the server's first progress shows up only after the clock reaches 600ms, by which point the call has already been rejected. Then I added 10ms of real time (a setTimeout captured before useFakeTimers) after each advanceTimersByTimeAsync. With that, all 12 variants passed on 3 of 3 runs, and SSE rejects with Maximum total timeout exceeded after 4 progress ticks, the same as the other transports.

The sleep only confirms the cause; it isn't a fix. protocol:timeout:reset-on-progress already avoids this race by awaiting vi.waitFor(() => expect(received.length).toBeGreaterThanOrEqual(i)) after each step, and max-total has no equivalent. Waiting until the server has received the call before advancing the clock should fix it. One wrinkle: vi.waitFor advances fake timers while it polls, so the wait needs to sit where it can't eat into the timeout budget under test.

Happy to open a test-only PR if that approach sounds right.

What did you expect?

The test passes regardless of machine speed, and actually exercises maxTotalTimeout over SSE.

Code to reproduce
cd test/e2e
pnpm vitest run scenarios/protocol.test.ts -t "timeout:basic|timeout:max-total"
# intermittent, so run it several times
SDK version

main @ 9bc40e90 (macOS / Darwin 27, Node 24.16.0, pnpm 10.26.1)

Area

Transports

Lingua principale
TypeScript
Stelle
13.6k
Fork
2.5k
Merge medio
1g 2h
PR unite (30g)
51

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modelcontextprotocol/typescript-sdk

Tutte le issue di modelcontextprotocol/typescript-sdk

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.