Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

fix(performance): go-faster counts paged reads and re-reads of growing task output as repeats

Aperta
  • Qualcosa non va?
#6,337 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
performance, tooling

Direzione di ricerca

Start in plugins/performance/scripts/findings.py around the Read and Bash transcript-count keys (near lines 897-898). Key reads on (file_path, offset, limit) and skip or downgrade Bash reads of session background-task output (tasks/*.output) and commands whose target changed. Add a regression test covering paged reads of one file and re-reads of a growing task output that expects no measured now-repeat findings.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs-triage priority: medium

Problem

/performance:go-faster's session-work area offers "Adopt now" batching findings for reads and commands that were not repeats.

findings.py transcript-counts keys a Read on file_path alone (plugins/performance/scripts/findings.py:897-898) and a Bash call on its command text. So:

  • Paged reads of one large file (same path, different offset/limit) count as the file "read 3 times".
  • Re-reading a background task's output file while the task is still writing to it counts as "the same command run 2 times", although its input changed between the two runs.

Both were offered as now items (session-work-2, session-work-3) with the advice "reuse the earlier output while its inputs are unchanged". Following it would have been wrong in both cases: the reused output would have been a different section of the file, or stale task output.

Evidence

Sweep run 20261004T190412Z, session 4c1577ca:

  • repeated_reads: a 109 KB handoff file read 3 times, at three different offsets, once each.
  • repeated_commands: cat <background task output> run twice, minutes apart, while the task appended to the file.

Fix

  • Key a Read on (file_path, offset, limit), so only an identical read counts as a repeat.
  • Do not count a Bash read of a file the session's background tasks write to (tasks/*.output), or a command whose target changed between runs, as a repeat. Where change cannot be detected, label the finding a candidate, not a measured now item.
  • Add a regression test with both shapes that expects no repeat finding.
Lingua principale
Shell
Stelle
22
Fork
2
Merge medio
5h 11m
PR unite (30g)
838

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di melodic-software/claude-code-plugins

Tutte le issue di melodic-software/claude-code-plugins

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.