fix(performance): go-faster counts paged reads and re-reads of growing task output as repeats
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- Medio día
- Aptitud para principiantes
- 72/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- python
- Área
- performance, tooling
Línea de trabajo
Start in plugins/performance/scripts/findings.py around the Read and Bash transcript-count keys (near lines 897-898). Key reads on (file_path, offset, limit) and skip or downgrade Bash reads of session background-task output (tasks/*.output) and commands whose target changed. Add a regression test covering paged reads of one file and re-reads of a growing task output that expects no measured now-repeat findings.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
/performance:go-faster's session-work area offers "Adopt now" batching findings for reads and commands that were not repeats.
findings.py transcript-counts keys a Read on file_path alone (plugins/performance/scripts/findings.py:897-898) and a Bash call on its command text. So:
- Paged reads of one large file (same path, different
offset/limit) count as the file "read 3 times". - Re-reading a background task's output file while the task is still writing to it counts as "the same command run 2 times", although its input changed between the two runs.
Both were offered as now items (session-work-2, session-work-3) with the advice "reuse the earlier output while its inputs are unchanged". Following it would have been wrong in both cases: the reused output would have been a different section of the file, or stale task output.
Evidence
Sweep run 20261004T190412Z, session 4c1577ca:
repeated_reads: a 109 KB handoff file read 3 times, at three different offsets, once each.repeated_commands:cat <background task output>run twice, minutes apart, while the task appended to the file.
Fix
- Key a Read on
(file_path, offset, limit), so only an identical read counts as a repeat. - Do not count a Bash read of a file the session's background tasks write to (
tasks/*.output), or a command whose target changed between runs, as a repeat. Where change cannot be detected, label the finding a candidate, not a measurednowitem. - Add a regression test with both shapes that expects no repeat finding.
- Lenguaje dominante
- Shell
- Estrellas
- 22
- Forks
- 2
- Merge medio
- 5 h 11 min
- PR fusionados (30 d)
- 838
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de melodic-software/claude-code-plugins
-
good first issue needs-triage priority: medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
melodic-software/claude-code-plugins#6631 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
melodic-software/claude-code-plugins#6547 ·
Los mantenedores suelen responder en 1 día
-
needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
melodic-software/claude-code-plugins#6535 ·
Los mantenedores suelen responder en 1 día
-
test_comment_census.py: SccArgv flag-shaped-filename test errors on Windows (#!/bin/sh scc shim)Abiertogood first issue needs-triage priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
melodic-software/claude-code-plugins#6532 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
good first issue needs-triage priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
melodic-software/claude-code-plugins#6390 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de melodic-software/claude-code-plugins
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
gnosis/gnosis_vpn#540 ·
Los mantenedores suelen responder en 1 día
-
Lid close does not lock the session on Apple Silicon (lid-close bind skips omarchy-system-lid-close)Abierto
Dificultad 1/5 1-3 horas Aptitud para principiantes 90/100
omacom/omarchy-mac#701 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
A 20.x release after 21.0.0 would move `latest` back to 20.x, and `next` stays on the release candidatePosiblemente ocupada @armando-navarro la tomó hoy. Abiertocomp: build/pipeline type: bug version: current (v17+)
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
angular/angularfire#3790 ·
Los mantenedores suelen responder en 3 días
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 86/100
omacom/omarchy#14490 · 1 comentario ·
Los mantenedores suelen responder en 1 día