Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

fix(performance): go-faster counts paged reads and re-reads of growing task output as repeats

Fermée
  • Quelque chose ne va pas ?
#6,337 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@kyle-sexton y travaille déjà.

Depuis le 11/10/2026.

  • #7085 par @kyle-sexton — ouverte

Évaluation

Difficulté
3/5
Temps estimé
Une demi-journée
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
python
Domaine
performance, tooling

Piste de recherche

Start in plugins/performance/scripts/findings.py around the Read and Bash transcript-count keys (near lines 897-898). Key reads on (file_path, offset, limit) and skip or downgrade Bash reads of session background-task output (tasks/*.output) and commands whose target changed. Add a regression test covering paged reads of one file and re-reads of a growing task output that expects no measured now-repeat findings.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

needs-triage priority: medium

Problem

/performance:go-faster's session-work area offers "Adopt now" batching findings for reads and commands that were not repeats.

findings.py transcript-counts keys a Read on file_path alone (plugins/performance/scripts/findings.py:897-898) and a Bash call on its command text. So:

  • Paged reads of one large file (same path, different offset/limit) count as the file "read 3 times".
  • Re-reading a background task's output file while the task is still writing to it counts as "the same command run 2 times", although its input changed between the two runs.

Both were offered as now items (session-work-2, session-work-3) with the advice "reuse the earlier output while its inputs are unchanged". Following it would have been wrong in both cases: the reused output would have been a different section of the file, or stale task output.

Evidence

Sweep run 20261004T190412Z, session 4c1577ca:

  • repeated_reads: a 109 KB handoff file read 3 times, at three different offsets, once each.
  • repeated_commands: cat <background task output> run twice, minutes apart, while the task appended to the file.

Fix

  • Key a Read on (file_path, offset, limit), so only an identical read counts as a repeat.
  • Do not count a Bash read of a file the session's background tasks write to (tasks/*.output), or a command whose target changed between runs, as a repeat. Where change cannot be detected, label the finding a candidate, not a measured now item.
  • Add a regression test with both shapes that expects no repeat finding.
Langage dominant
Shell
Étoiles
22
Forks
2
Merge moyen
8 h 34 min
PR mergées (30 j)
946

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de melodic-software/claude-code-plugins

Toutes les issues de melodic-software/claude-code-plugins

Issues similaires

Plus d'issues Shell/Bash

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.