bug(openai): a stream that fails mid-iteration ends the generation without level ERROR
I maintainer di solito rispondono entro 1 giorno
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Describe the bug
When an OpenAI chat stream fails after the first chunk, the generation ends with no level and no status_message. The caller gets openai.APIError, while Langfuse shows a normal generation holding the partial output. The same failure before the stream starts is recorded as ERROR.
The cause is in langfuse/openai.py. _wrap catches only what create() raises. Exceptions raised while iterating go through traced_iterator's finally (line 1112) into _finalize_stream_response, which calls generation.end() with no error. The async path (_instrument_openai_async_stream) and LangfuseResponseGeneratorSync/Async do the same.
To reproduce
import httpx
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
from langfuse import Langfuse
from langfuse.openai import OpenAI
exporter = InMemorySpanExporter()
provider = TracerProvider()
provider.add_span_processor(SimpleSpanProcessor(exporter))
Langfuse(public_key="pk", secret_key="sk", base_url="http://127.0.0.1:9", tracer_provider=provider)
SSE = (
b'data: {"id":"c1","object":"chat.completion.chunk","created":1,"model":"gpt-4o-mini",'
b'"choices":[{"index":0,"delta":{"role":"assistant","content":"Hel"},"finish_reason":null}]}\n\n'
b'data: {"error":{"message":"The server had an error while processing your request.","type":"server_error"}}\n\n'
)
client = OpenAI(api_key="x", http_client=httpx.Client(transport=httpx.MockTransport(
lambda r: httpx.Response(200, headers={"content-type": "text/event-stream"}, content=SSE))))
stream = client.chat.completions.create(name="failed-stream", model="gpt-4o-mini",
messages=[{"role": "user", "content": "hi"}], stream=True)
try:
for chunk in stream:
pass
except Exception as e:
print("caller saw :", type(e).__name__, e)
a = next(s for s in exporter.get_finished_spans() if s.name == "failed-stream").attributes
print("level :", a.get("langfuse.observation.level"))
print("status_msg :", a.get("langfuse.observation.status_message"))
print("output :", a.get("langfuse.observation.output"))
$ python lf_stream_error.py 2>/dev/null
caller saw : APIError The server had an error while processing your request.
level : None
status_msg : None
output : Hel
With the transport answering 500 to create(stream=True) instead, the generation records ERROR | Error code: 500 - {'error': {'message': 'server_error'}}. The AsyncOpenAI version of the failing stream also prints level: None.
Expected
level="ERROR" and status_message=str(error) on the generation, with the partial output and any usage kept. The OpenAI integration docs say Langfuse "automatically tracks and monitors OpenAI API errors" in level and statusMessage, and test_chat_completion_error_marks_generation_error pins that for the non-streaming case.
SDK versions
langfuse 5.0.2 at 81c457c, openai 3.35.1, opentelemetry-sdk 1.45.1, Python 3.12. Not checked: the Responses API, where a response.failed event raises nothing.
@hassiebp I'd catch the exception in each iterator wrapper, set the error on the generation, and re-raise. A test using the SSE body above can live next to the existing break test in tests/unit/test_openai.py. Shall I open that PR?
- Lingua principale
- Python
- Stelle
- 504
- Fork
- 391
- Merge medio
- 1g 1h
- PR unite (30g)
- 64
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di langfuse/langfuse-python
-
bug(scores): create_score sends numpy.bool_ as JSON `true` and Decimal as "<Decimal>" since v5.0.2Forse già presa @lalith0407 l’ha presa 4 giorni fa. Apertabug feat-scores sdk-python
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
langfuse/langfuse-python#2057 ·
I maintainer di solito rispondono entro 1 giorno
-
tests/unit/test_prompt.py fails on a fresh clone without LANGFUSE_* env varsForse già presa @Mathoholic l’ha presa 18 giorni fa. Apertabug feat-prompt-management sdk-python
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
langfuse/langfuse-python#1976 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
fix(serializer): handle single-string __slots__ and detect cycles in slotted objectsForse già presa @hassiebp l’ha presa 13 giorni fa. Apertabug sdk-python
langfuse/langfuse-python#2014 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
bug: ChatPromptClient.compile appends str(whole list) once per non-dict placeholder itemForse già presa @nimarb l’ha presa 8 giorni fa. Apertabug feat-prompt-management sdk-python
langfuse/langfuse-python#1971 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
bug: GCS upload detection in MediaManager uses substring match on the full URLForse già presa @hassiebp l’ha presa 29 giorni fa. Apertabug feat-multimodal-media sdk-python
langfuse/langfuse-python#1913 · 1 commento · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di langfuse/langfuse-python
Issue simili
-
factory
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
Arize-ai/phoenix#17420 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
FireDynamics/LEDSmokeAnalysis#176 ·
I maintainer di solito rispondono entro 1 giorno
-
PC
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 1 giorno
-
Make `ocifs` optionalApertadependencies
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
dlt-contrib/dlt-filesystem#51 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno