Validator client: support Electra, Fulu and Gloas only; drop Lean and pre-Electra fork handling
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start with the listed fork handling in crates/validator, especially beacon_node/block_contents.rs, beacon_node/http.rs, and lib.rs, then inspect the boundary tests in attestation.rs and signing.rs. First decide whether Electra remains supported; the issue describes the tradeoff but leaves it open. Done means startup rejects unsupported schedules, client fork matches cover the chosen forks, and the boundary tests target the new supported range.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
The validator client (crates/validator) should support Electra, Fulu and Gloas only, and stop carrying code for ForkName::Lean and the pre-Electra forks.
Why
The client already only works from Electra on. It submits SingleAttestations to /eth/v2/beacon/pool/attestations at every fork. It also refuses pre-Electra blocks (ProducedBlock::from_ssz) and aggregates ("electra is the earliest supported"). Every network we run against (mainnet, Sepolia, Hoodi, Platåberget) is past Electra.
The code still handles the earlier forks anyway, and Lean shows up only because ForkName is shared with the lean chain in ethlambda-types. Config::fork_at_epoch never returns Lean. Each of these branches guards a state that can't occur, but a reviewer still has to reason about it. The review of #789 spent several comments on this: whether the Lean arm's error is retryable, and whether committee 0 is right before Electra.
Line numbers below are as of 9be2506c:
- Arms that exist only to fail.
Phase0 | Altair | Bellatrix | Capella | Deneb | Leanarms appear inbeacon_node/block_contents.rs:316andbeacon_node/http.rs:881. #789 addshighest_attestation_indexwith a pre-Electra arm and aLeanarm, which returns a retryableInconsistentResponseafter the request was already made. - Pre-Gloas attestation data is requested under the slot's own fork, as far back as Phase0.
a_pre_gloas_slot_is_asked_about_under_its_own_forkassertsForkName::Phase0.attestation_data_pathsendscommittee_index=0before Gloas, and every validator signs that same data. That would also be wrong before Electra, wheredata.indexmust be the attester's own committee. - The sync committee subscription gate checks
< ForkName::Altair(lib.rs:817). - Tests pinned to the Phase0/Altair boundary:
attestation.rs:769-818(theEth-Consensus-Versionheader test) and the boundary tests insigning.rs(around lines 461, 621 and 703).
Proposal
- Refuse to start before Electra. If the beacon node's schedule (from
/eth/v1/config/spec) puts the current epoch before Electra, stop at startup with one clear error. - Give the client its own fork type, e.g.
enum ValidatorFork { Electra, Fulu, Gloas }withTryFrom<ForkName>. Convert once, wherefork_at_epochis called, so everymatchin the client has three arms and noLeanor pre-Electra ones. A fork added after Gloas still breaks every match until someone decides what it means. - Remove the pre-Electra branches: the
< Altairsync gate, the pre-Electra andLeanarms in block and aggregate decoding and inhighest_attestation_index, and comments that describe pre-Electra semantics (e.g. the index as a committee). - Move the boundary tests from Phase0/Altair to the Electra/Fulu or Fulu/Gloas boundary, so they still check that headers and domains follow the right epoch.
Consider dropping Electra too
Every network the client targets is already past Fulu:
- mainnet: Fulu at epoch 411392, December 2025
- Sepolia: epoch 272640
- Hoodi: epoch 50688
- Platåberget and the kurtosis battery (
tooling/kurtosis-assertoor/network_params.yaml): Fulu from genesis
Supporting only Fulu and Gloas would remove the code that exists for Electra alone. That mainly means the per-blob-proof block contents (ProducedBlock::from_ssz's Electra arm and Contents::WithBlobProofs, which Fulu's cell proofs replaced) and whatever publishes them. It would also move the many tests that use Electra as their default fork over to Fulu. The startup check in step 1 would then refuse anything before Fulu, and the client's fork type would have two variants.
The cost is losing any network that is still on Electra, such as a local devnet configured with Electra at genesis and a later Fulu epoch. Worth deciding before step 2, since it changes the enum.
Out of scope
config_from_spec_responsekeeps parsing the whole fork schedule. Fork versions and epochs are configuration, not fork handling.- The
altair::sync committee containers stay. They are the containers in use today, not pre-Electra support.
- Lingua principale
- Rust
- Stelle
- 86
- Fork
- 34
- Merge medio
- 9g 20h
- PR unite (30g)
- 77
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di lambdaclass/ethlambda
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
lambdaclass/ethlambda#850 ·
I maintainer di solito rispondono entro 6 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
lambdaclass/ethlambda#777 · 1 reazione ·
I maintainer di solito rispondono entro 6 giorni
-
Run all gossip validation testsForse di nuovo libera @dicethedev l’ha presa 9 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
lambdaclass/ethlambda#725 · 2 commenti ·
I maintainer di solito rispondono entro 6 giorni
-
Handle malformed DB dataForse di nuovo libera @dicethedev l’ha presa 115 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
lambdaclass/ethlambda#529 · 4 commenti ·
I maintainer di solito rispondono entro 6 giorni
-
Document architectural choicesForse di nuovo libera @dicethedev l’ha presa 115 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
lambdaclass/ethlambda#521 · 2 commenti ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di lambdaclass/ethlambda
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
antithesishq/bombadil#473 ·
I maintainer di solito rispondono entro 2 giorni
-
bench/api.sh exec test fails with curl exit 52, and --ignore-failure still records the timingsApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
libracoder/kiri#669 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
I maintainer di solito rispondono entro 5 giorni
-
autofixer: follow-up
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
tursodatabase/turso#12217 ·
I maintainer di solito rispondono entro 1 giorno
-
Declare the CMS schema library in the optional recipients extraForse già presa Una pull request collegata a questa issue è aperta o già unita. Apertaarea:python in-progress
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
yhay81/pyropdf#1005 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno