Validator client: support Electra, Fulu and Gloas only; drop Lean and pre-Electra fork handling
Los mantenedores suelen responder en 6 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start with the listed fork handling in crates/validator, especially beacon_node/block_contents.rs, beacon_node/http.rs, and lib.rs, then inspect the boundary tests in attestation.rs and signing.rs. First decide whether Electra remains supported; the issue describes the tradeoff but leaves it open. Done means startup rejects unsupported schedules, client fork matches cover the chosen forks, and the boundary tests target the new supported range.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
The validator client (crates/validator) should support Electra, Fulu and Gloas only, and stop carrying code for ForkName::Lean and the pre-Electra forks.
Why
The client already only works from Electra on. It submits SingleAttestations to /eth/v2/beacon/pool/attestations at every fork. It also refuses pre-Electra blocks (ProducedBlock::from_ssz) and aggregates ("electra is the earliest supported"). Every network we run against (mainnet, Sepolia, Hoodi, Platåberget) is past Electra.
The code still handles the earlier forks anyway, and Lean shows up only because ForkName is shared with the lean chain in ethlambda-types. Config::fork_at_epoch never returns Lean. Each of these branches guards a state that can't occur, but a reviewer still has to reason about it. The review of #789 spent several comments on this: whether the Lean arm's error is retryable, and whether committee 0 is right before Electra.
Line numbers below are as of 9be2506c:
- Arms that exist only to fail.
Phase0 | Altair | Bellatrix | Capella | Deneb | Leanarms appear inbeacon_node/block_contents.rs:316andbeacon_node/http.rs:881. #789 addshighest_attestation_indexwith a pre-Electra arm and aLeanarm, which returns a retryableInconsistentResponseafter the request was already made. - Pre-Gloas attestation data is requested under the slot's own fork, as far back as Phase0.
a_pre_gloas_slot_is_asked_about_under_its_own_forkassertsForkName::Phase0.attestation_data_pathsendscommittee_index=0before Gloas, and every validator signs that same data. That would also be wrong before Electra, wheredata.indexmust be the attester's own committee. - The sync committee subscription gate checks
< ForkName::Altair(lib.rs:817). - Tests pinned to the Phase0/Altair boundary:
attestation.rs:769-818(theEth-Consensus-Versionheader test) and the boundary tests insigning.rs(around lines 461, 621 and 703).
Proposal
- Refuse to start before Electra. If the beacon node's schedule (from
/eth/v1/config/spec) puts the current epoch before Electra, stop at startup with one clear error. - Give the client its own fork type, e.g.
enum ValidatorFork { Electra, Fulu, Gloas }withTryFrom<ForkName>. Convert once, wherefork_at_epochis called, so everymatchin the client has three arms and noLeanor pre-Electra ones. A fork added after Gloas still breaks every match until someone decides what it means. - Remove the pre-Electra branches: the
< Altairsync gate, the pre-Electra andLeanarms in block and aggregate decoding and inhighest_attestation_index, and comments that describe pre-Electra semantics (e.g. the index as a committee). - Move the boundary tests from Phase0/Altair to the Electra/Fulu or Fulu/Gloas boundary, so they still check that headers and domains follow the right epoch.
Consider dropping Electra too
Every network the client targets is already past Fulu:
- mainnet: Fulu at epoch 411392, December 2025
- Sepolia: epoch 272640
- Hoodi: epoch 50688
- Platåberget and the kurtosis battery (
tooling/kurtosis-assertoor/network_params.yaml): Fulu from genesis
Supporting only Fulu and Gloas would remove the code that exists for Electra alone. That mainly means the per-blob-proof block contents (ProducedBlock::from_ssz's Electra arm and Contents::WithBlobProofs, which Fulu's cell proofs replaced) and whatever publishes them. It would also move the many tests that use Electra as their default fork over to Fulu. The startup check in step 1 would then refuse anything before Fulu, and the client's fork type would have two variants.
The cost is losing any network that is still on Electra, such as a local devnet configured with Electra at genesis and a later Fulu epoch. Worth deciding before step 2, since it changes the enum.
Out of scope
config_from_spec_responsekeeps parsing the whole fork schedule. Fork versions and epochs are configuration, not fork handling.- The
altair::sync committee containers stay. They are the containers in use today, not pre-Electra support.
- Lenguaje dominante
- Rust
- Estrellas
- 86
- Forks
- 34
- Merge medio
- 9 d 20 h
- PR fusionados (30 d)
- 77
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de lambdaclass/ethlambda
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
lambdaclass/ethlambda#850 ·
Los mantenedores suelen responder en 6 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
lambdaclass/ethlambda#777 · 1 reacción ·
Los mantenedores suelen responder en 6 días
-
Run all gossip validation testsQuizá libre de nuevo @dicethedev la tomó hace 9 días y no hay ningún pull request abierto. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
lambdaclass/ethlambda#725 · 2 comentarios ·
Los mantenedores suelen responder en 6 días
-
Handle malformed DB dataQuizá libre de nuevo @dicethedev la tomó hace 115 días y no hay ningún pull request abierto. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
lambdaclass/ethlambda#529 · 4 comentarios ·
Los mantenedores suelen responder en 6 días
-
Document architectural choicesQuizá libre de nuevo @dicethedev la tomó hace 115 días y no hay ningún pull request abierto. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
lambdaclass/ethlambda#521 · 2 comentarios ·
Los mantenedores suelen responder en 6 días
Todos los issues de lambdaclass/ethlambda
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
antithesishq/bombadil#473 ·
Los mantenedores suelen responder en 2 días
-
bench/api.sh exec test fails with curl exit 52, and --ignore-failure still records the timingsAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
libracoder/kiri#669 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
Los mantenedores suelen responder en 5 días
-
autofixer: follow-up
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
tursodatabase/turso#12217 ·
Los mantenedores suelen responder en 1 día
-
Declare the CMS schema library in the optional recipients extraPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertoarea:python in-progress
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
yhay81/pyropdf#1005 · 2 comentarios ·
Los mantenedores suelen responder en 1 día