Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

App.axaml comment claims the Simple theme has no Dark dictionary; audit dark-mode overrides

Aperta
  • Qualcosa non va?
#4,151 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
accessibility, design, desktop

Direzione di ricerca

Start with the comment and theme dictionaries around lines 35-40 of ILSpy/App.axaml, then inspect Avalonia.Themes.Simple/Accents/Base.xaml for its Default and Dark entries. Audit the ILSpy.* overrides and Simple-themed controls that use the listed variant-independent keys. Done means the comment is accurate, unnecessary overrides are identified or removed, and dark-mode contrast issues like #4146 are addressed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Follow-up from #4150 (fix for #4146).

Stale comment

The comment above the theme dictionaries in ILSpy/App.axaml (around lines 35-40) says:

The Simple theme itself ships no Dark resource dictionary, so chrome painted by Simple (menu, scrollbars, tree, status bar) stays Light regardless of the user's theme choice. Intentional, partial dark mode targeting only the surfaces a reader spends most time looking at.

That is no longer true for the Avalonia version we are on (12.1.2). Avalonia.Themes.Simple/Accents/Base.xaml has ResourceDictionary.ThemeDictionaries with a Default and a Dark entry, and most Theme*Color / Theme*Brush keys vary between them (e.g. ThemeForegroundColor #FF000000 vs #FFDEDEDE, ThemeControlHighlightMidColor #FFD0D0D0 vs #FF828282).

What Simple does not vary per variant are the keys defined outside those dictionaries:

  • ThemeForegroundLowColor / ThemeForegroundLowBrush (#FF808080)
  • ThemeAccentColor, ThemeAccentColor2/3/4 and their brushes (#CC/99/66/33119EDA)

Those fixed keys are what caused #4146 (fixed #808080 text on the Dark #828282 hover fill).

To do
  • Rewrite the comment so it describes what Simple 12.1.2 actually provides and which keys stay fixed.
  • Audit which of our ILSpy.* overrides and restyles exist only because of the old assumption and could now lean on Simple's own Dark dictionary instead.
  • Audit other Simple-themed controls that use the variant-independent keys (ThemeForegroundLowBrush, ThemeAccentBrush*) for the same kind of dark-mode contrast problem as #4146.

Assisted-by: Claude:claude-fable-5-1:Claude Code

Lingua principale
C#
Stelle
26.6k
Fork
3.8k
Merge medio
1g 16h
PR unite (30g)
76

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di icsharpcode/ILSpy

Tutte le issue di icsharpcode/ILSpy

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.