App.axaml comment claims the Simple theme has no Dark dictionary; audit dark-mode overrides
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- csharp
- 领域
- accessibility, design, desktop
调研方向
Start with the comment and theme dictionaries around lines 35-40 of ILSpy/App.axaml, then inspect Avalonia.Themes.Simple/Accents/Base.xaml for its Default and Dark entries. Audit the ILSpy.* overrides and Simple-themed controls that use the listed variant-independent keys. Done means the comment is accurate, unnecessary overrides are identified or removed, and dark-mode contrast issues like #4146 are addressed.
由索引模型根据 Issue 内容生成。
描述
Follow-up from #4150 (fix for #4146).
Stale comment
The comment above the theme dictionaries in ILSpy/App.axaml (around lines 35-40) says:
The Simple theme itself ships no Dark resource dictionary, so chrome painted by Simple (menu, scrollbars, tree, status bar) stays Light regardless of the user's theme choice. Intentional, partial dark mode targeting only the surfaces a reader spends most time looking at.
That is no longer true for the Avalonia version we are on (12.1.2). Avalonia.Themes.Simple/Accents/Base.xaml has ResourceDictionary.ThemeDictionaries with a Default and a Dark entry, and most Theme*Color / Theme*Brush keys vary between them (e.g. ThemeForegroundColor #FF000000 vs #FFDEDEDE, ThemeControlHighlightMidColor #FFD0D0D0 vs #FF828282).
What Simple does not vary per variant are the keys defined outside those dictionaries:
ThemeForegroundLowColor/ThemeForegroundLowBrush(#FF808080)ThemeAccentColor,ThemeAccentColor2/3/4and their brushes (#CC/99/66/33119EDA)
Those fixed keys are what caused #4146 (fixed #808080 text on the Dark #828282 hover fill).
To do
- Rewrite the comment so it describes what Simple 12.1.2 actually provides and which keys stay fixed.
- Audit which of our
ILSpy.*overrides and restyles exist only because of the old assumption and could now lean on Simple's own Dark dictionary instead. - Audit other Simple-themed controls that use the variant-independent keys (
ThemeForegroundLowBrush,ThemeAccentBrush*) for the same kind of dark-mode contrast problem as #4146.
Assisted-by: Claude:claude-fable-5-1:Claude Code
- 主要语言
- C#
- 星标
- 26.8k
- 派生
- 3.8k
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 71
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
icsharpcode/ILSpy 的其他 Issue
-
External UI
难度 1/5 1-3 小时 新手友好度 75/100
icsharpcode/ILSpy#4284 ·
维护者通常 1 天内回复
-
CSharpDecompiler reads the XML documentation file with ShowXmlDocumentation off可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 74/100
icsharpcode/ILSpy#4275 ·
维护者通常 1 天内回复
-
AI
难度 4/5 1-2 天 新手友好度 55/100
icsharpcode/ILSpy#4300 ·
维护者通常 1 天内回复
-
Enhancement
难度 4/5 3-5 天 新手友好度 48/100
icsharpcode/ILSpy#4298 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
Bug
难度 3/5 1-2 天 新手友好度 67/100
icsharpcode/ILSpy#4295 ·
维护者通常 1 天内回复
查看 icsharpcode/ILSpy 的全部 Issue
相似的 Issue
-
area-blazor NativeAOT Regression
难度 2/5 1-3 小时 新手友好度 62/100
dotnet/aspnetcore#70236 · 1 条评论 ·
维护者通常 1 天内回复
-
bug priority: P2
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
bug evaluation required
难度 1/5 1-3 小时 新手友好度 78/100
MaterialDesignInXAML/MaterialDesignInXamlToolkit#4118 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复