Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Mojolicious controller and WebSocket lifetimes regress with #1642 integration

Aperta
  • Qualcosa non va?
#1,794 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@fglock ci sta già lavorando.

Dal 15/10/2026.

  • #1816 di @fglock — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
12/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java, perl
Ambito
backend, compilers

Direzione di ricerca

Start with the failing upstream tests t/mojolicious/app.t (assertion near line 703, 'controller has been destroyed') and t/mojolicious/websocket_lite_app.t (assertion near line 322, missing server push). The issue says the work depends on the unmerged #1642 cleanup, so first confirm its final commit. Done means both tests pass again with focused PerlOnJava regression coverage added. Expect JVM reachability and GC-level reasoning, and check with maintainers before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

The #1642 cleanup changes appear to introduce two Mojolicious runtime regressions in addition to the DOM behavior being fixed by that work. Please triage after #1642 is merged or its implementation settles; this report records integration evidence and avoids duplicating the weak-reference cleanup fix.

Reproduction and evidence

In a disposable integration checkout merging PerlOnJava3 PR #1777 (47e9bfb78f1ac790143838fafcf92f852147bc2b) with the #1642 work in PerlOnJava5 PR #1746 (46d9200e5553bc645fe38b4ee341433aff8ae958), the upstream Mojolicious tests fail:

  • t/mojolicious/app.t: assertion at line 703 reports controller has been destroyed (system Perl passes all 458 assertions).
  • t/mojolicious/websocket_lite_app.t: assertion at line 322 reports Server push message not received; expected push, got an empty value (system Perl passes all 35 assertions).

Both tests pass on the unmerged PerlOnJava3 #1777 branch using the same Mojolicious source and dependencies. In the integration checkout they fail after the #1642 changes are merged. The focused t/mojo/dom.t test passes in the integration checkout, consistent with the intended DOM cleanup improvement.

The integration build was b124844c9 (test-only merge commit); neither review branch was changed. The full upstream test run used IO::Compress 2.223. The colorized log-format failure in t/mojo/log.t is environment-dependent and is not part of this report.

Expected behavior

A controller used by the active request remains alive through response handling, and a WebSocket server push is delivered to the connected client.

Requested follow-up

After #1642 lands, reproduce these two failures on its final commit, inspect whether the new aggregate cleanup / reachability behavior is reclaiming objects still owned by active requests or WebSocket callbacks, and add focused PerlOnJava regression coverage for each confirmed behavior. The existing upstream tests already provide precise reproductions.

Lingua principale
Perl
Stelle
64
Fork
7
Merge medio
5h 39m
PR unite (30g)
213

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fglock/PerlOnJava

Tutte le issue di fglock/PerlOnJava

Issue simili

Altre issue su Perl

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.