Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Mojolicious controller and WebSocket lifetimes regress with #1642 integration

Abierto
  • ¿Algo no está bien?
#1,794 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
12/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java, perl
Área
backend, compilers

Línea de trabajo

Start with the failing upstream tests t/mojolicious/app.t (assertion near line 703, 'controller has been destroyed') and t/mojolicious/websocket_lite_app.t (assertion near line 322, missing server push). The issue says the work depends on the unmerged #1642 cleanup, so first confirm its final commit. Done means both tests pass again with focused PerlOnJava regression coverage added. Expect JVM reachability and GC-level reasoning, and check with maintainers before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

The #1642 cleanup changes appear to introduce two Mojolicious runtime regressions in addition to the DOM behavior being fixed by that work. Please triage after #1642 is merged or its implementation settles; this report records integration evidence and avoids duplicating the weak-reference cleanup fix.

Reproduction and evidence

In a disposable integration checkout merging PerlOnJava3 PR #1777 (47e9bfb78f1ac790143838fafcf92f852147bc2b) with the #1642 work in PerlOnJava5 PR #1746 (46d9200e5553bc645fe38b4ee341433aff8ae958), the upstream Mojolicious tests fail:

  • t/mojolicious/app.t: assertion at line 703 reports controller has been destroyed (system Perl passes all 458 assertions).
  • t/mojolicious/websocket_lite_app.t: assertion at line 322 reports Server push message not received; expected push, got an empty value (system Perl passes all 35 assertions).

Both tests pass on the unmerged PerlOnJava3 #1777 branch using the same Mojolicious source and dependencies. In the integration checkout they fail after the #1642 changes are merged. The focused t/mojo/dom.t test passes in the integration checkout, consistent with the intended DOM cleanup improvement.

The integration build was b124844c9 (test-only merge commit); neither review branch was changed. The full upstream test run used IO::Compress 2.223. The colorized log-format failure in t/mojo/log.t is environment-dependent and is not part of this report.

Expected behavior

A controller used by the active request remains alive through response handling, and a WebSocket server push is delivered to the connected client.

Requested follow-up

After #1642 lands, reproduce these two failures on its final commit, inspect whether the new aggregate cleanup / reachability behavior is reclaiming objects still owned by active requests or WebSocket callbacks, and add focused PerlOnJava regression coverage for each confirmed behavior. The existing upstream tests already provide precise reproductions.

Lenguaje dominante
Perl
Estrellas
64
Forks
7
Merge medio
5 h 25 min
PR fusionados (30 d)
213

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fglock/PerlOnJava

Todos los issues de fglock/PerlOnJava

Issues similares

Más issues de Perl

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.