Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Mojolicious controller and WebSocket lifetimes regress with #1642 integration

Ouverte
  • Quelque chose ne va pas ?
#1,794 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
12/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
java, perl
Domaine
backend, compilers

Piste de recherche

Start with the failing upstream tests t/mojolicious/app.t (assertion near line 703, 'controller has been destroyed') and t/mojolicious/websocket_lite_app.t (assertion near line 322, missing server push). The issue says the work depends on the unmerged #1642 cleanup, so first confirm its final commit. Done means both tests pass again with focused PerlOnJava regression coverage added. Expect JVM reachability and GC-level reasoning, and check with maintainers before starting.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

The #1642 cleanup changes appear to introduce two Mojolicious runtime regressions in addition to the DOM behavior being fixed by that work. Please triage after #1642 is merged or its implementation settles; this report records integration evidence and avoids duplicating the weak-reference cleanup fix.

Reproduction and evidence

In a disposable integration checkout merging PerlOnJava3 PR #1777 (47e9bfb78f1ac790143838fafcf92f852147bc2b) with the #1642 work in PerlOnJava5 PR #1746 (46d9200e5553bc645fe38b4ee341433aff8ae958), the upstream Mojolicious tests fail:

  • t/mojolicious/app.t: assertion at line 703 reports controller has been destroyed (system Perl passes all 458 assertions).
  • t/mojolicious/websocket_lite_app.t: assertion at line 322 reports Server push message not received; expected push, got an empty value (system Perl passes all 35 assertions).

Both tests pass on the unmerged PerlOnJava3 #1777 branch using the same Mojolicious source and dependencies. In the integration checkout they fail after the #1642 changes are merged. The focused t/mojo/dom.t test passes in the integration checkout, consistent with the intended DOM cleanup improvement.

The integration build was b124844c9 (test-only merge commit); neither review branch was changed. The full upstream test run used IO::Compress 2.223. The colorized log-format failure in t/mojo/log.t is environment-dependent and is not part of this report.

Expected behavior

A controller used by the active request remains alive through response handling, and a WebSocket server push is delivered to the connected client.

Requested follow-up

After #1642 lands, reproduce these two failures on its final commit, inspect whether the new aggregate cleanup / reachability behavior is reclaiming objects still owned by active requests or WebSocket callbacks, and add focused PerlOnJava regression coverage for each confirmed behavior. The existing upstream tests already provide precise reproductions.

Langage dominant
Perl
Étoiles
64
Forks
7
Merge moyen
5 h 25 min
PR mergées (30 j)
213

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fglock/PerlOnJava

Toutes les issues de fglock/PerlOnJava

Issues similaires

Plus d'issues Perl

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.