test(browser): flaky browser specs (WebKit drag, Firefox import waitForEvent)

Aperta
#416 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
75/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, playwright, react
Ambito
frontend, testing

Direzione di ricerca

Start with the drag test near line 256 and the press() helper near line 48 in tests/browser/menu-drag.spec.js. Reproduce with the provided Playwright command using WebKit and repeated runs; inspect other press() callers for one-time reads after 150 ms. Determine whether waiting for the chip result or confirming the drop target before release addresses the failure, then verify the flaky case no longer reproduces.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:tests

The WebKit test "dragging still works › the Month chip by its handle, after its menu was used, moves to Rows" failed once on #415's CI and passed on the retry. The run was https://github.com/eizedev/pivotkit/actions/runs/43685334063, job "browser (webkit 1/2, React 19)". #415 touches neither the test nor the drag code.

Where: tests/browser/menu-drag.spec.js, in the test at line 256 and the press() helper at line 48.

What failed:

  • The assertion before it passed: the dragged chip followed the pointer, and there was one .pk-overlay after the last move.
  • chips(page, "rows") was still ["City"], not ["City", "Date by month of year"]. The check at line 263 reads the chips once, 150 ms after mouse.up().

The cause is not confirmed yet. There are two candidates:

  1. On a busy runner the drop's state update is drawn more than 150 ms after the release, so the single read comes too early.
  2. press() releases right after its last move. If WebKit fires mouseup before dnd-kit has recorded the Rows zone as the target, the drop lands nowhere.

Reproduce: npx playwright test tests/browser/menu-drag.spec.js -g "by its handle" --project=webkit --repeat-each=30 --retries=0, ideally under CPU load.

Fix:

  • For candidate 1: wait for the result instead of reading it once, with await expect.poll(() => chips(page, "rows")).toEqual(["City", MONTH]). Do the same for cols.
  • For candidate 2: in press(), before the release, wait until the target zone shows that it will take the drop.
  • Check the other callers of press() for the same one-time read after 150 ms.
Lingua principale
JavaScript
Stelle
1
Fork
1
Merge medio
3h 34m
PR unite (30g)
213

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di eizedev/pivotkit

Tutte le issue di eizedev/pivotkit

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.