test(browser): flaky browser specs (WebKit drag, Firefox import waitForEvent)

Ouverte
#416 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
75/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, playwright, react
Domaine
frontend, testing

Piste de recherche

Start with the drag test near line 256 and the press() helper near line 48 in tests/browser/menu-drag.spec.js. Reproduce with the provided Playwright command using WebKit and repeated runs; inspect other press() callers for one-time reads after 150 ms. Determine whether waiting for the chip result or confirming the drop target before release addresses the failure, then verify the flaky case no longer reproduces.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:tests

The WebKit test "dragging still works › the Month chip by its handle, after its menu was used, moves to Rows" failed once on #415's CI and passed on the retry. The run was https://github.com/eizedev/pivotkit/actions/runs/43685334063, job "browser (webkit 1/2, React 19)". #415 touches neither the test nor the drag code.

Where: tests/browser/menu-drag.spec.js, in the test at line 256 and the press() helper at line 48.

What failed:

  • The assertion before it passed: the dragged chip followed the pointer, and there was one .pk-overlay after the last move.
  • chips(page, "rows") was still ["City"], not ["City", "Date by month of year"]. The check at line 263 reads the chips once, 150 ms after mouse.up().

The cause is not confirmed yet. There are two candidates:

  1. On a busy runner the drop's state update is drawn more than 150 ms after the release, so the single read comes too early.
  2. press() releases right after its last move. If WebKit fires mouseup before dnd-kit has recorded the Rows zone as the target, the drop lands nowhere.

Reproduce: npx playwright test tests/browser/menu-drag.spec.js -g "by its handle" --project=webkit --repeat-each=30 --retries=0, ideally under CPU load.

Fix:

  • For candidate 1: wait for the result instead of reading it once, with await expect.poll(() => chips(page, "rows")).toEqual(["City", MONTH]). Do the same for cols.
  • For candidate 2: in press(), before the release, wait until the target zone shows that it will take the drop.
  • Check the other callers of press() for the same one-time read after 150 ms.
Langage dominant
JavaScript
Étoiles
1
Forks
1
Merge moyen
3 h 34 min
PR mergées (30 j)
213

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de eizedev/pivotkit

Toutes les issues de eizedev/pivotkit

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.