test(browser): flaky browser specs (WebKit drag, Firefox import waitForEvent)

Abierto
#416 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
75/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, playwright, react
Área
frontend, testing

Línea de trabajo

Start with the drag test near line 256 and the press() helper near line 48 in tests/browser/menu-drag.spec.js. Reproduce with the provided Playwright command using WebKit and repeated runs; inspect other press() callers for one-time reads after 150 ms. Determine whether waiting for the chip result or confirming the drop target before release addresses the failure, then verify the flaky case no longer reproduces.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:tests

The WebKit test "dragging still works › the Month chip by its handle, after its menu was used, moves to Rows" failed once on #415's CI and passed on the retry. The run was https://github.com/eizedev/pivotkit/actions/runs/43685334063, job "browser (webkit 1/2, React 19)". #415 touches neither the test nor the drag code.

Where: tests/browser/menu-drag.spec.js, in the test at line 256 and the press() helper at line 48.

What failed:

  • The assertion before it passed: the dragged chip followed the pointer, and there was one .pk-overlay after the last move.
  • chips(page, "rows") was still ["City"], not ["City", "Date by month of year"]. The check at line 263 reads the chips once, 150 ms after mouse.up().

The cause is not confirmed yet. There are two candidates:

  1. On a busy runner the drop's state update is drawn more than 150 ms after the release, so the single read comes too early.
  2. press() releases right after its last move. If WebKit fires mouseup before dnd-kit has recorded the Rows zone as the target, the drop lands nowhere.

Reproduce: npx playwright test tests/browser/menu-drag.spec.js -g "by its handle" --project=webkit --repeat-each=30 --retries=0, ideally under CPU load.

Fix:

  • For candidate 1: wait for the result instead of reading it once, with await expect.poll(() => chips(page, "rows")).toEqual(["City", MONTH]). Do the same for cols.
  • For candidate 2: in press(), before the release, wait until the target zone shows that it will take the drop.
  • Check the other callers of press() for the same one-time read after 150 ms.
Lenguaje dominante
JavaScript
Estrellas
1
Forks
1
Merge medio
3 h 34 min
PR fusionados (30 d)
213

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eizedev/pivotkit

Todos los issues de eizedev/pivotkit

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.