Fix Bot Mention Trigger Silently Discarded by Queue Worker Due to Raw Event Name Mismatch
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 67/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- github, node.js, typescript
- Ambito
- backend-api-design, devops
Direzione di ricerca
Read packages/core/src/review/resolve-job.ts and trace how it loads webhook_deliveries; compare that path with normalization in packages/provider-github/src/webhook.ts and delivery creation in packages/api/src/routes/webhook.ts. Start with the tests around resolveQueuedJob and add coverage for an issue_comment delivery and a closed pull_request delivery. Done means mention reviews and PR-close label cleanup run, existing auto-triggered reviews still work, and the listed typecheck, test, and lint commands pass.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Mention-triggered reviews (e.g. @codra review posted as a PR comment) are silently dropped before they ever reach the review worker. The pipeline queues the message, but the worker discards it immediately because it checks for a normalized event name that was never stored.
Root Cause
The webhook handler in packages/api/src/routes/webhook.ts reads the raw GitHub header x-github-event (value: "issue_comment") and stores it in the webhook_deliveries table as-is.
When the queue worker calls resolveQueuedJob in packages/core/src/review/resolve-job.ts, it loads the delivery and checks:
if (eventName !== "change_request" && eventName !== "comment") {
logger.info(`Queue message ignored: unsupported webhook event ${eventName}`);
return null;
}
Since delivery.event_name is "issue_comment" (raw GitHub header), not "comment" (the normalized name), the check fails and the message is thrown away. Mention-triggered reviews never execute.
The same mismatch applies to pull_request to change_request for PR-close label cleanup. Any job that takes the fallback path through the delivery lookup (without an inline jobId or payload on the queue message) can be affected.
Affected Files
packages/api/src/routes/webhook.ts- stores raweventNamein delivery and passes it raw to the queue message (L274-278)packages/core/src/review/resolve-job.ts- checks normalized names against raw stored names (L42-50)packages/provider-github/src/webhook.ts-normalizeGitHubWebhookcorrectly maps"issue_comment"to"comment", but is never called on the worker path
Proposed Fix
In resolveQueuedJob, after loading the delivery record, normalize eventName before checking:
// After loading delivery:
const normalized = env.webhooks.normalizePayload(delivery.event_name, delivery.payload);
if (normalized) {
eventName = normalized.eventName; // "comment" or "change_request"
payload = normalized.payload;
} else {
eventName = delivery.event_name;
payload = delivery.payload as WebhookPayload;
}
Alternatively (and more robustly), store the normalized event name in webhook_deliveries at insertion time in the webhook route, so the queue always receives the canonical name regardless of which path it takes.
Done When
-
@codra reviewcomments on a PR trigger a review job correctly - PR-close label cleanup runs for
pull_requestclosed events - Existing auto-triggered PR reviews (
opened,synchronize, etc.) continue to work - Tests cover the mention trigger path end-to-end through
resolveQueuedJob - Any backend changes work in both Cloudflare Workers and Node/Docker
-
npm run typecheck,npm test, andnpm run lintall pass
Before Closing
-
npm run typecheck,npm test, andnpm run lintall pass - Any backend changes work in both Cloudflare Workers and Node/Docker
- Tests cover the changed behavior in each affected runtime
- Lingua principale
- TypeScript
- Stelle
- 125
- Fork
- 23
- Merge medio
- 2g 13h
- PR unite (30g)
- 12
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di devarshishimpi/codra
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
devarshishimpi/codra#178 ·
I maintainer di solito rispondono entro 1 giorno
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
devarshishimpi/codra#176 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
devarshishimpi/codra#186 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
devarshishimpi/codra#185 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
devarshishimpi/codra#184 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di devarshishimpi/codra
Issue simili
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 83/100
gofish-graphics/gofish-graphics#1384 ·
I maintainer di solito rispondono entro 1 giorno
-
adapter bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
Olanetsoft/agent-lookout#353 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
vicharanashala/vibe#1542 ·
I maintainer di solito rispondono entro 1 giorno
-
bug chore P2 size:XS
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
josephfung/curia#2666 ·
I maintainer di solito rispondono entro 1 giorno
-
area: batch
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
inabagumi/shinju-date#7294 ·
I maintainer di solito rispondono entro 1 giorno